Issue 8607001: views: Factor out Listener from Combobox into its own header file.

Issue 8607001: views: Factor out Listener from Combobox into its own header file. (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Factor out Listener from Combobox into its own header file. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111165

Patch Set 2 : sky review #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -70 lines)			Patch
M	chrome/browser/chromeos/options/vpn_config_view.h	View		2 chunks	+15 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/options/vpn_config_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.h	View		3 chunks	+15 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/options/wifi_config_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h	View		3 chunks	+12 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/cookie_info_view.h	View		4 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/views/cookie_info_view.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/uninstall_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/uninstall_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/examples/combobox_example.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	ui/views/examples/combobox_example.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/examples/native_theme_button_example.h	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/views/examples/native_theme_button_example.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/examples/text_example.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/views/examples/text_example.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	views/controls/combobox/combobox.h	View		2 chunks	+5 lines, -14 lines	0 comments	Download
M	views/controls/combobox/combobox.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	views/controls/combobox/combobox_listener.h	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
M	views/views.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/8607001/diff/7001/views/controls/combobox/combobox_listener.h File views/controls/combobox/combobox_listener.h (right): http://codereview.chromium.org/8607001/diff/7001/views/controls/combobox/combobox_listener.h#newcode14 views/controls/combobox/combobox_listener.h:14: // changed. add 'of a combobx' here.

9 years, 1 month ago (2011-11-21 16:18:25 UTC) #2

tfarina

9 years, 1 month ago (2011-11-21 16:43:06 UTC) #3

http://codereview.chromium.org/8607001/diff/7001/views/controls/combobox/comb...
File views/controls/combobox/combobox_listener.h (right):

http://codereview.chromium.org/8607001/diff/7001/views/controls/combobox/comb...
views/controls/combobox/combobox_listener.h:14: // changed.
On 2011/11/21 16:18:25, sky wrote:
> add 'of a combobx' here.

Done.

Expand Messages | Collapse Messages