chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc - Issue 8607001: views: Factor out Listener from Combobox into its own header file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

Issue 8607001: views: Factor out Listener from Combobox into its own header file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sky review Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

index 35cdd17d6020c14296c54eeb6052f89134b21283..7938e6b193a845c32680726ee26607b03da0701d 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc

@@ -26,6 +26,7 @@

#include "ui/views/layout/grid_layout.h"

#include "ui/views/layout/layout_constants.h"

#include "views/controls/button/text_button.h"

+#include "views/controls/combobox/combobox.h"

#include "views/controls/label.h"

#include "views/controls/link.h"

#include "views/controls/textfield/textfield.h"

@@ -279,7 +280,7 @@ void BookmarkBubbleView::LinkClicked(views::Link* source, int event_flags) {

StartFade(false);

}

-void BookmarkBubbleView::ItemChanged(views::Combobox* combobox,

+void BookmarkBubbleView::ItemChanged(views::Combobox* combo_box,

int prev_index,

int new_index) {

if (new_index + 1 == parent_model_.GetItemCount()) {