Move SSL layer initialization into ChannelAuthenticator implementations.

remoting/protocol/pepper_channel.h

Index: remoting/protocol/pepper_channel.h
diff --git a/remoting/protocol/pepper_channel.h b/remoting/protocol/pepper_channel.h
index cb77b17d5cfac9a7c30202c3e53a133a81a55b3d..4ba07192f65b69f5496e90a73d2df64a32b47ec1 100644
--- a/remoting/protocol/pepper_channel.h
+++ b/remoting/protocol/pepper_channel.h
@@ -21,6 +21,7 @@ class Candidate;
 namespace remoting {
 namespace protocol {
 
+class ChannelAuthenticator;
 struct TransportConfig;
 
 // Interface for stream and datagram channels used by PepperSession.
@@ -29,10 +30,11 @@ class PepperChannel : public base::NonThreadSafe {
   PepperChannel() { }
   virtual ~PepperChannel() { }
 
-  // Connect the channel using specified |config|.
+  // Connect the channel using specified |config|. Takes ownership of
+  // |authenticator|.

[Wez, 2011/11/22 22:29:48]

nit: How is |pp_instance| used, and owned?  How is |authenticator| used?  Is
|authenticator| torn down once authentication is complete, for example, or kept
around and torn down with the channel?

[Sergey Ulanov, 2011/11/23 01:23:42]

There is always only one pp_instance per plugin, so it is not owned, and I don't
think it is necessary to specify that it is not owned everywhere where we pass
it around because it is obvious.
In the current implementation it is kept around while channel exists, but it may
be as well destroyed after authentication is finished - it doesn't make any
difference. I don't think it is important to specify it here, as it is a detail
of correct ChannelAuthenticator usage. The only aspect a caller may need to care
about is that the authenticator is destroyed before or when PepperChannel
instance is destroyed - but I don't think it is necessary to explicitly specify
it here.

   virtual void Connect(pp::Instance* pp_instance,
                        const TransportConfig& config,
-                       const std::string& remote_cert) = 0;
+                       ChannelAuthenticator* authenticator) = 0;
 
   // Adds |candidate| received from the peer.
   virtual void AddRemoveCandidate(const cricket::Candidate& candidate) = 0;