Move SSL layer initialization into ChannelAuthenticator implementations.

remoting/protocol/pepper_channel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_PEPPER_CHANNEL_H_
 #define REMOTING_PROTOCOL_PEPPER_CHANNEL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/threading/non_thread_safe.h"
 
 namespace pp {
 class Instance;
 }  // namespace pp
 
 namespace cricket {
 class Candidate;
 }  // namespace cricket
 
 namespace remoting {
 namespace protocol {
 
+class ChannelAuthenticator;
 struct TransportConfig;
 
 // Interface for stream and datagram channels used by PepperSession.
 class PepperChannel : public base::NonThreadSafe {
  public:
   PepperChannel() { }
   virtual ~PepperChannel() { }
 
-  // Connect the channel using specified |config|.
+  // Connect the channel using specified |config|. Takes ownership of
+  // |authenticator|.

[Wez, 2011/11/22 22:29:48]

nit: How is |pp_instance| used, and owned?  How is |authenticator| used?  Is
|authenticator| torn down once authentication is complete, for example, or kept
around and torn down with the channel?

[Sergey Ulanov, 2011/11/23 01:23:42]

There is always only one pp_instance per plugin, so it is not owned, and I don't
think it is necessary to specify that it is not owned everywhere where we pass
it around because it is obvious.
In the current implementation it is kept around while channel exists, but it may
be as well destroyed after authentication is finished - it doesn't make any
difference. I don't think it is important to specify it here, as it is a detail
of correct ChannelAuthenticator usage. The only aspect a caller may need to care
about is that the authenticator is destroyed before or when PepperChannel
instance is destroyed - but I don't think it is necessary to explicitly specify
it here.

   virtual void Connect(pp::Instance* pp_instance,
                        const TransportConfig& config,
-                       const std::string& remote_cert) = 0;
+                       ChannelAuthenticator* authenticator) = 0;
 
   // Adds |candidate| received from the peer.
   virtual void AddRemoveCandidate(const cricket::Candidate& candidate) = 0;
 
   // Name of the channel.
   virtual const std::string& name() const = 0;
 
   // returns true if the channel is already connected
   virtual bool is_connected() const = 0;
 
  protected:
   DISALLOW_COPY_AND_ASSIGN(PepperChannel);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_PEPPER_CHANNEL_H_