Panels: Disable auto-resize if initial size is specified during creation.

chrome/browser/ui/panels/panel.h

Index: chrome/browser/ui/panels/panel.h
diff --git a/chrome/browser/ui/panels/panel.h b/chrome/browser/ui/panels/panel.h
index 64ff50c78eefb25575e497014a1db6e8acb42930..53b4c7fb5f7b70c7d96b703b61fe49ab787dca59 100644
--- a/chrome/browser/ui/panels/panel.h
+++ b/chrome/browser/ui/panels/panel.h
@@ -204,6 +204,7 @@ class Panel : public BrowserWindow,
   ExpansionState expansion_state() const { return expansion_state_; }
   const gfx::Size& min_size() const { return min_size_; }
   const gfx::Size& max_size() const { return max_size_; }
+  bool auto_resizable() { return auto_resizable_; }

[jianli, 2011/11/18 23:03:32]

const.

[jennb, 2011/11/18 23:26:00]

Done.

 
  protected:
   virtual void DestroyBrowser() OVERRIDE;
@@ -222,13 +223,20 @@ class Panel : public BrowserWindow,
   //   not allowed for Panel.
   void SetPanelBounds(const gfx::Rect& bounds);
 
-  // Updates the maximum size.
+  // Updates the maximum/minimum size.
   void SetMaxSize(const gfx::Size& max_size);
+  void SetMinSize(const gfx::Size& min_size);
+
+  // Sets whether the panel will auto resize according to its content.
+  void SetAutoResizable(bool resizable);
 
   // NULL might be returned if the tab has not been added.
   RenderViewHost* GetRenderViewHost() const;
 
-  void EnableAutoResize(RenderViewHost* render_view_host);
+  // Sets up necessary configuration to make tab contents resizable.
+  void SetUpAutoResize(TabContents* tab_contents);

[jianli, 2011/11/18 23:03:32]

'SetUpAutoResize' seems to be easily confused with SetAutoResizable. How about
making the method name more explicit, like EnableAutoResizeForTabContents?

[jennb, 2011/11/18 23:26:00]

Done.

+
+  void EnableRendererAutoResize(RenderViewHost* render_view_host);

[Dmitry Titov, 2011/11/18 23:00:34]

A comment for this second method could explain why similar-looking methods are
needed...

[jennb, 2011/11/18 23:26:00]

Sure. Though this function should go away after Dave's refactor because then it
will only require one renderer call to set up auto-resize instead of having to
use a helper to group both calls together.

 
   // Requests RenderViewHost not to show the scrollbars till |max_size_| since
   // the panel can grow to |max_size_|.
@@ -242,6 +250,9 @@ class Panel : public BrowserWindow,
   // the growing content and WebKit would add the scrollbars in such case.
   gfx::Size max_size_;
 
+  // True if this panel auto resizes based on content.
+  bool auto_resizable_;
+
   // Platform specifc implementation for panels.  It'd be one of
   // PanelBrowserWindowGtk/PanelBrowserView/PanelBrowserWindowCocoa.
   NativePanel* native_panel_;  // Weak, owns us.