Panels: Disable auto-resize if initial size is specified during creation.

chrome/browser/ui/panels/panel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PANELS_PANEL_H_
 #define CHROME_BROWSER_UI_PANELS_PANEL_H_
 #pragma once
 
 #include "chrome/browser/ui/browser_window.h"
 
@@ skipping 186 matching lines @@
   void OnWindowSizeAvailable();
 
   // Asynchronous completion of panel close request.
   void OnNativePanelClosed();
 
   NativePanel* native_panel() { return native_panel_; }
   Browser* browser() const;
   ExpansionState expansion_state() const { return expansion_state_; }
   const gfx::Size& min_size() const { return min_size_; }
   const gfx::Size& max_size() const { return max_size_; }
+  bool auto_resizable() { return auto_resizable_; }

[jianli, 2011/11/18 23:03:32]

const.

[jennb, 2011/11/18 23:26:00]

Done.

 
  protected:
   virtual void DestroyBrowser() OVERRIDE;
 
  private:
   friend class PanelManager;
   friend class PanelBrowserTest;
   FRIEND_TEST_ALL_PREFIXES(PanelBrowserTest, RestoredBounds);
 
   // Panel can only be created using PanelManager::CreatePanel().
   Panel(Browser* browser, const gfx::Rect& bounds);
 
   // This is different from BrowserWindow::SetBounds():
   // * SetPanelBounds() is only called by PanelManager to manage its position.
   // * SetBounds() is called by the API to try to change the bounds, which is
   //   not allowed for Panel.
   void SetPanelBounds(const gfx::Rect& bounds);
 
-  // Updates the maximum size.
+  // Updates the maximum/minimum size.
   void SetMaxSize(const gfx::Size& max_size);
+  void SetMinSize(const gfx::Size& min_size);
+
+  // Sets whether the panel will auto resize according to its content.
+  void SetAutoResizable(bool resizable);
 
   // NULL might be returned if the tab has not been added.
   RenderViewHost* GetRenderViewHost() const;
 
-  void EnableAutoResize(RenderViewHost* render_view_host);
+  // Sets up necessary configuration to make tab contents resizable.
+  void SetUpAutoResize(TabContents* tab_contents);

[jianli, 2011/11/18 23:03:32]

'SetUpAutoResize' seems to be easily confused with SetAutoResizable. How about
making the method name more explicit, like EnableAutoResizeForTabContents?

[jennb, 2011/11/18 23:26:00]

Done.

+
+  void EnableRendererAutoResize(RenderViewHost* render_view_host);

[Dmitry Titov, 2011/11/18 23:00:34]

A comment for this second method could explain why similar-looking methods are
needed...

[jennb, 2011/11/18 23:26:00]

Sure. Though this function should go away after Dave's refactor because then it
will only require one renderer call to set up auto-resize instead of having to
use a helper to group both calls together.

 
   // Requests RenderViewHost not to show the scrollbars till |max_size_| since
   // the panel can grow to |max_size_|.
   void RequestRenderViewHostToDisableScrollbars(
       RenderViewHost* render_view_host);
 
   // This is the minimum size that the panel can shrink to.
   gfx::Size min_size_;
 
   // This is the size beyond which the panel is not going to grow to accomodate
   // the growing content and WebKit would add the scrollbars in such case.
   gfx::Size max_size_;
 
+  // True if this panel auto resizes based on content.
+  bool auto_resizable_;
+
   // Platform specifc implementation for panels.  It'd be one of
   // PanelBrowserWindowGtk/PanelBrowserView/PanelBrowserWindowCocoa.
   NativePanel* native_panel_;  // Weak, owns us.
 
   ExpansionState expansion_state_;
 
   // Stores the full height of the panel so we can restore it after it's
   // been minimized.
   int restored_height_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(Panel);
 };
 
 #endif  // CHROME_BROWSER_UI_PANELS_PANEL_H_