Issue 8601004: Remove --enable-video-logging and WebVideoRenderer.

Issue 8601004: Remove --enable-video-logging and WebVideoRenderer. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 1 month ago

Reviewers:
tony, acolwell GONE FROM CHROMIUM, jam, Ami GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), pam+watch_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove --enable-video-logging and WebVideoRenderer. WebVideoRenderer was added in r40137 as part of my IPC-based video rendering experiment. I later added --enable-video-logging in r43038 which was intended to log timestamps and do logs analysis to determine playback smoothness. This again was experimental and never used. Also removed WebMediaPlayerProxy::SetRect() and VideoRendererImpl::SetRect() as they were not implemented. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110786

Patch Set 1 #

Patch Set 2 : forgot gypi #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -128 lines)			Patch
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View		2 chunks	+1 line, -9 lines	0 comments	Download
M	webkit/media/video_renderer_impl.h	View		2 chunks	+12 lines, -10 lines	0 comments	Download
M	webkit/media/video_renderer_impl.cc	View		3 chunks	+4 lines, -16 lines	0 comments	Download
D	webkit/media/web_video_renderer.h	View		1 chunk	+0 lines, -47 lines	0 comments	Download
M	webkit/media/webkit_media.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/media/webmediaplayer_impl.h	View		4 chunks	+4 lines, -8 lines	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View		4 chunks	+7 lines, -8 lines	0 comments	Download
M	webkit/media/webmediaplayer_proxy.h	View		3 chunks	+3 lines, -4 lines	0 comments	Download
M	webkit/media/webmediaplayer_proxy.cc	View		3 chunks	+2 lines, -9 lines	0 comments	Download
M	webkit/support/webkit_support.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

fischman: I'll take what I can get!!! jam: OWNERS content/*/* tony: OWNERS webkit/*/*

9 years, 1 month ago (2011-11-18 05:52:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/8601004/2001

9 years, 1 month ago (2011-11-18 19:31:49 UTC) #7

commit-bot: I haz the power

9 years, 1 month ago (2011-11-18 20:40:39 UTC) #8

Try job failure for 8601004-2001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages