Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: webkit/media/video_renderer_impl.cc

Issue 8601004: Remove --enable-video-logging and WebVideoRenderer. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: forgot gypi Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/media/video_renderer_impl.h ('k') | webkit/media/web_video_renderer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/video_renderer_impl.cc
diff --git a/webkit/media/video_renderer_impl.cc b/webkit/media/video_renderer_impl.cc
index 955512f14483ba161601868bc98f82606f7e1856..01bc04856757264ac01a1d1a2cb24c9415060801 100644
--- a/webkit/media/video_renderer_impl.cc
+++ b/webkit/media/video_renderer_impl.cc
@@ -13,9 +13,10 @@
namespace webkit_media {
-VideoRendererImpl::VideoRendererImpl(bool pts_logging)
- : last_converted_frame_(NULL),
- pts_logging_(pts_logging) {
+VideoRendererImpl::VideoRendererImpl(
+ const scoped_refptr<WebMediaPlayerProxy>& proxy)
+ : proxy_(proxy),
+ last_converted_frame_(NULL) {
}
VideoRendererImpl::~VideoRendererImpl() {}
@@ -39,12 +40,6 @@ void VideoRendererImpl::OnFrameAvailable() {
proxy_->Repaint();
}
-void VideoRendererImpl::SetWebMediaPlayerProxy(WebMediaPlayerProxy* proxy) {
- proxy_ = proxy;
-}
-
-void VideoRendererImpl::SetRect(const gfx::Rect& rect) {}
-
// This method is always called on the renderer's thread.
void VideoRendererImpl::Paint(SkCanvas* canvas, const gfx::Rect& dest_rect) {
scoped_refptr<media::VideoFrame> video_frame;
@@ -64,13 +59,6 @@ void VideoRendererImpl::Paint(SkCanvas* canvas, const gfx::Rect& dest_rect) {
} else {
SlowPaint(video_frame, canvas, dest_rect);
}
-
- // Presentation timestamp logging is primarily used to measure performance
- // on low-end devices. When profiled on an Intel Atom N280 @ 1.66GHz this
- // code had a ~63 microsecond perf hit when logging to a file (not stdout),
- // which is neglible enough for measuring playback performance.
- if (pts_logging_)
- VLOG(1) << "pts=" << video_frame->GetTimestamp().InMicroseconds();
}
PutCurrentFrame(video_frame);
« no previous file with comments | « webkit/media/video_renderer_impl.h ('k') | webkit/media/web_video_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698