Issue 8599004: Fix webkit_media::WebMediaPlayerProxy memory leak due to circular refcounting.

Issue 8599004: Fix webkit_media::WebMediaPlayerProxy memory leak due to circular refcounting. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 1 month ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, hclam+watch_chromium.org, Alexander Potapenko, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, Timur Iskhodzhanov, annacc+watch_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), stuartmorgan+watch_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix webkit_media::WebMediaPlayerProxy memory leak due to circular refcounting. BUG=100583 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110660

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -22 lines)			Patch
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download
M	webkit/media/webmediaplayer_proxy.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/media/webmediaplayer_proxy.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

http://codereview.chromium.org/8599004/diff/1/tools/valgrind/memcheck/suppressions.txt File tools/valgrind/memcheck/suppressions.txt (left): http://codereview.chromium.org/8599004/diff/1/tools/valgrind/memcheck/suppressions.txt#oldcode3773 tools/valgrind/memcheck/suppressions.txt:3773: { ignore -- this was committed as http://crrev.com/110627

9 years, 1 month ago (2011-11-18 03:10:12 UTC) #2

Ami GONE FROM CHROMIUM

LGTM++ For bonus points write a clang plugin to detect this...._ = Bind(&..., this, ...) ...

9 years, 1 month ago (2011-11-18 03:12:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/8599004/1

9 years, 1 month ago (2011-11-18 03:46:54 UTC) #4

commit-bot: I haz the power

Can't apply patch for file tools/valgrind/memcheck/suppressions.txt. While running patch -p1 --forward --force; patching file tools/valgrind/memcheck/suppressions.txt ...

9 years, 1 month ago (2011-11-18 03:46:56 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/8599004/3003

9 years, 1 month ago (2011-11-18 03:51:09 UTC) #6

Change committed as 110660

Expand Messages | Collapse Messages