webkit/media/webmediaplayer_proxy.cc - Issue 8599004: Fix webkit_media::WebMediaPlayerProxy memory leak due to circular refcounting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/media/webmediaplayer_proxy.cc

Issue 8599004: Fix webkit_media::WebMediaPlayerProxy memory leak due to circular refcounting. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src

Patch Set: rebase Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/media/webmediaplayer_proxy.cc

diff --git a/webkit/media/webmediaplayer_proxy.cc b/webkit/media/webmediaplayer_proxy.cc

index a596ed8faec274814f72830acd6ddede38a715be..cec34e3de5e9db77e2f2bd16d291c45736639147 100644

--- a/webkit/media/webmediaplayer_proxy.cc

+++ b/webkit/media/webmediaplayer_proxy.cc

@@ -50,9 +50,7 @@ void WebMediaPlayerProxy::SetVideoRenderer(

}

WebDataSourceBuildObserverHack WebMediaPlayerProxy::GetBuildObserver() {

- if (build_observer_.is_null())

- build_observer_ = base::Bind(&WebMediaPlayerProxy::AddDataSource, this);

- return build_observer_;

+ return base::Bind(&WebMediaPlayerProxy::AddDataSource, this);

}

void WebMediaPlayerProxy::Paint(SkCanvas* canvas, const gfx::Rect& dest_rect) {

« no previous file with comments | « webkit/media/webmediaplayer_proxy.h ('k') | no next file » | no next file with comments »