Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 8598029: Revert 110361 - NaCl: preallocate shared-memory object on Linux as on MacOSX (Closed)

Created:
9 years, 1 month ago by Roland McGrath
Modified:
9 years, 1 month ago
Reviewers:
Roland McGrath
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Revert 110361 - NaCl: preallocate shared-memory object on Linux as on MacOSX Preallocating the shared memory object saves an IPC round trip. It also makes the code path more similar for Linux and Mac. It also lays the groundwork for changing the allocation method later without having to replumb the proxying layer. BUG= http://code.google.com/p/chromium/issues/detail?id=103377 TEST= nacl still works on Linux R=mseaborn@chromium.org,jam@chromium.org Review URL: http://codereview.chromium.org/8513018 TBR=mseaborn@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110776

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -48 lines) Patch
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +5 lines, -5 lines 0 comments Download
MM chrome/nacl/nacl_listener.cc View 2 chunks +27 lines, -43 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
9 years, 1 month ago (2011-11-18 22:51:53 UTC) #1
Mark Seaborn
Please state why you're reverting this.
9 years, 1 month ago (2011-11-18 22:59:23 UTC) #2
Roland McGrath
9 years, 1 month ago (2011-11-18 23:05:54 UTC) #3
On 2011/11/18 22:59:23, Mark Seaborn wrote:
> Please state why you're reverting this.

http://code.google.com/p/chromium/issues/detail?id=104664

resolution still under investigation

Powered by Google App Engine
This is Rietveld 408576698