NaCl: preallocate shared-memory object on Linux as on MacOSX

NaCl: preallocate shared-memory object on Linux as on MacOSX

Preallocating the shared memory object saves an IPC round trip.
It also makes the code path more similar for Linux and Mac.
It also lays the groundwork for changing the allocation method
later without having to replumb the proxying layer.

BUG= http://code.google.com/p/chromium/issues/detail?id=103377
TEST= nacl still works on Linux

R=mseaborn@chromium.org,jam@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110361

[Mark Seaborn, 2011-11-16 19:13:33]

On 16 November 2011 11:06, <mcgrathr@chromium.org> wrote:

> Reviewers: Mark Seaborn, John Abd-El-Malek,
>
> Description:
> NaCl: preallocate shared-memory object on Linux as on MacOSX
>
> Preallocating the shared memory object saves an IPC round trip.
> It also makes the code path more similar for Linux and Mac.
> It also lays the groundwork for changing the allocation method
> later without having to replumb the proxying layer.
>
> As MakeSharedMemorySegmentViaIPC no longer has any users, remove it.
>

MakeSharedMemorySegmentViaIPC() is still used on Linux by the
imc_mem_obj_create() syscall.  There's even a test for that syscall for the
in-browser case (tests/inbrowser_test_runner runs it).

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Mark Seaborn, 2011-11-16 19:13:36]

On 16 November 2011 11:06, <mcgrathr@chromium.org> wrote:

> Reviewers: Mark Seaborn, John Abd-El-Malek,
>
> Description:
> NaCl: preallocate shared-memory object on Linux as on MacOSX
>
> Preallocating the shared memory object saves an IPC round trip.
> It also makes the code path more similar for Linux and Mac.
> It also lays the groundwork for changing the allocation method
> later without having to replumb the proxying layer.
>
> As MakeSharedMemorySegmentViaIPC no longer has any users, remove it.
>

MakeSharedMemorySegmentViaIPC() is still used on Linux by the
imc_mem_obj_create() syscall.  There's even a test for that syscall for the
in-browser case (tests/inbrowser_test_runner runs it).

Mark

[Roland McGrath, 2011-11-16 19:36:35]

PTAL

[Mark Seaborn, 2011-11-16 19:41:15]

On 2011/11/16 19:36:35, Roland McGrath wrote:
> PTAL

LGTM