command_wrapper.py - Issue 8597020: Ensure that all args with spaces in them remain quoted when used with command_wrapper.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: command_wrapper.py

Issue 8597020: Ensure that all args with spaces in them remain quoted when used with command_wrapper.py. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/command_wrapper/bin/

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: command_wrapper.py

===================================================================

--- command_wrapper.py (revision 109830)

+++ command_wrapper.py (working copy)

@@ -95,8 +95,15 @@

socket.setdefaulttimeout(10)

command_id = uuid.uuid1()

- cmd = ' '.join(args)

+ # Ensure that args with spaces in them remain quoted.

+ args_quoted = []

bradn 2011/11/19 01:09:13 Why not just requote it all?

+ for arg in args:

+ if ' ' in arg:

+ arg = '"' + arg + '"'

+ args_quoted.append(arg)

+ cmd = ' '.join(args_quoted)

# Log that we're even starting.

RunWithTimeout(LOG_TIMEOUT, LogCommand,

options, command_id, -1, cmd, -1, '', '', 0)

« no previous file with comments | « no previous file | no next file » | no next file with comments »