Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 8597020: Ensure that all args with spaces in them remain quoted when used with command_wrapper.py. (Closed)

Created:
9 years, 1 month ago by Nicolas Sylvain
Modified:
9 years, 1 month ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews
Visibility:
Public.

Description

Ensure that all args with spaces in them remain quoted when used with command_wrapper.py. Before this change, a command like : echo "1" "2" "3 4" would be executed as : echo 1 2 3 4 After this change, it will be executed as: echo 1 2 "3 4" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111020

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M command_wrapper.py View 1 chunk +8 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
Nicolas Sylvain
9 years, 1 month ago (2011-11-19 00:03:30 UTC) #1
bradn
LGTM http://codereview.chromium.org/8597020/diff/1/command_wrapper.py File command_wrapper.py (right): http://codereview.chromium.org/8597020/diff/1/command_wrapper.py#newcode100 command_wrapper.py:100: args_quoted = [] Why not just requote it ...
9 years, 1 month ago (2011-11-19 01:09:13 UTC) #2
bradn
Probably safer to do the least change. LGTM
9 years, 1 month ago (2011-11-21 22:45:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nsylvain@chromium.org/8597020/1
9 years, 1 month ago (2011-11-21 22:47:05 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 22:47:12 UTC) #5
Change committed as 111020

Powered by Google App Engine
This is Rietveld 408576698