[Sync] Parse and save per-data type throttle data

chrome/browser/sync/protocol/sync.proto

Index: chrome/browser/sync/protocol/sync.proto
diff --git a/chrome/browser/sync/protocol/sync.proto b/chrome/browser/sync/protocol/sync.proto
index b4e182618e4c2458ad8a31532ace5ce085b9a24b..f6e9bbdfd4c34b81397a53e0e5cfc4f82b878e1f 100644
--- a/chrome/browser/sync/protocol/sync.proto
+++ b/chrome/browser/sync/protocol/sync.proto
@@ -420,7 +420,7 @@ message ClearUserDataResponse {
 
 message ClientToServerMessage {
   required string share = 1;
-  optional int32 protocol_version = 2 [default = 29];
+  optional int32 protocol_version = 2 [default = 30];
   enum Contents {
     COMMIT = 1;
     GET_UPDATES = 2;
@@ -650,6 +650,10 @@ message ClientToServerResponse {
       UNKNOWN_ACTION              = 5; // This is the default.
     }
     optional Action action              = 4 [default = UNKNOWN_ACTION];
+
+    // Meaningful if the |error_type| is throttled. If this field is absent
+    // then the whole client(all datatypes) is throttled.

[akalin, 2011/11/21 20:04:26]

space before (

[lipalani1, 2011/11/21 21:55:38]

Not sure I understand?
On 2011/11/21 20:04:26, akalin wrote:

+    repeated int32 throttled_data_type_ids = 5;

[akalin, 2011/11/21 20:04:26]

i think this should be named more generically, like error_data_type_ids, and the
comment moved to TRANSIENT_ERROR above

[lipalani1, 2011/11/21 21:55:38]

Renamed. Not sure I understand the rest of the comment.
On 2011/11/21 20:04:26, akalin wrote:

   }
 
   optional Error error = 13;