[Sync] Parse and save per-data type throttle data

chrome/browser/sync/protocol/sync.proto

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Sync protocol for communication between sync client and server.
 
 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
 // any fields in this file.
 
 syntax = "proto2";
@@ skipping 402 matching lines @@
 // response is returned to the client indicating that the server has received
 // the request and has begun to clear data.
 message ClearUserDataMessage {
 }
 
 message ClearUserDataResponse {
 }
 
 message ClientToServerMessage {
   required string share = 1;
-  optional int32 protocol_version = 2 [default = 29];
+  optional int32 protocol_version = 2 [default = 30];
   enum Contents {
     COMMIT = 1;
     GET_UPDATES = 2;
     AUTHENTICATE = 3;
     CLEAR_DATA = 4;
   }
 
   required Contents message_contents = 3;
   optional CommitMessage commit = 4;
   optional GetUpdatesMessage get_updates = 5;
@@ skipping 186 matching lines @@
                               // Google Account.
     AUTH_INVALID       = 6;   // Auth token or cookie is otherwise invalid.
     CLEAR_PENDING      = 7;   // A clear of the user data is pending (e.g.
                               // initiated by privacy request).  Client should
                               // come back later.
     TRANSIENT_ERROR    = 8;   // A transient error occured (eg. backend
                               // timeout). Client should try again later.
     MIGRATION_DONE     = 9;   // Migration has finished for one or more data
                               // types.  Client should clear the cache for
                               // these data types only and then re-sync with
                               // a server.

[akalin, 2011/11/21 20:04:26]

add a comment about how migrated_data_type_id is used (for legacy reasons)
instead of new error_data_type_ids field in Error

[lipalani1, 2011/11/21 21:55:38]

Done.

     UNKNOWN            = 100; // Unknown value. This should never be explicitly
                               // used; it is the default value when an
                               // out-of-date client parses a value it doesn't
                               // recognize.
   }
 
   message Error {
     optional ErrorType error_type       = 1 [default = UNKNOWN];
     optional string error_description   = 2;
     optional string url                 = 3;
     enum Action {
       UPGRADE_CLIENT              = 0; // Upgrade the client to latest version.
       CLEAR_USER_DATA_AND_RESYNC  = 1; // Clear user data from dashboard and
                                        // setup sync again.
       ENABLE_SYNC_ON_ACCOUNT      = 2; // The administrator needs to enable sync
                                        // on the account.
       STOP_AND_RESTART_SYNC       = 3; // Stop sync and set up sync again.
       DISABLE_SYNC_ON_CLIENT      = 4; // Wipe the client of all sync data and
                                        // stop syncing.
       UNKNOWN_ACTION              = 5; // This is the default.
     }
     optional Action action              = 4 [default = UNKNOWN_ACTION];
+
+    // Meaningful if the |error_type| is throttled. If this field is absent
+    // then the whole client(all datatypes) is throttled.

[akalin, 2011/11/21 20:04:26]

space before (

[lipalani1, 2011/11/21 21:55:38]

Not sure I understand?
On 2011/11/21 20:04:26, akalin wrote:

+    repeated int32 throttled_data_type_ids = 5;

[akalin, 2011/11/21 20:04:26]

i think this should be named more generically, like error_data_type_ids, and the
comment moved to TRANSIENT_ERROR above

[lipalani1, 2011/11/21 21:55:38]

Renamed. Not sure I understand the rest of the comment.
On 2011/11/21 20:04:26, akalin wrote:

   }
 
   optional Error error = 13;
 
   // Up until protocol_version 24, the default was SUCCESS which made it
   // impossible to add new enum values since older clients would parse any
   // out-of-range value as SUCCESS. Starting with 25, unless explicitly set,
   // the error_code will be UNKNOWN so that clients know when they're
   // out-of-date. Note also that when using protocol_version < 25,
   // TRANSIENT_ERROR is not supported. Instead, the server sends back a HTTP
   // 400 error code. This is deprecated now.
   optional ErrorType error_code = 4 [default = UNKNOWN];
   optional string error_message = 5;
 
   // Opaque store ID; if it changes, the contents of the client's cache
   // is meaningless to this server.  This happens most typically when
   // you switch from one storage backend instance (say, a test instance)
   // to another (say, the official instance).
   optional string store_birthday = 6;
 
   optional ClientCommand client_command = 7;
   optional ProfilingData profiling_data = 8;
 
   // The data types whose storage has been migrated.  Present when the value of
   // error_code is MIGRATION_DONE.
   repeated int32 migrated_data_type_id = 12;
 };