Issue 8595020: Cleanup old code and refresh on IDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8595020: Cleanup old code and refresh on IDL (Closed)

Created:
9 years, 1 month ago by vsm

Modified:
9 years, 1 month ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup old code and refresh on IDL Note, this picks up Pavel's custom->any IDL change. Committed: https://code.google.com/p/dart/source/detail?r=1690

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -203 lines)			Patch
M	client/dom/frog/frog_dom.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	client/dom/generated/monkey_dom.js	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	client/dom/generated/monkey_dom_externs.js	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	client/dom/generated/src/frog/CanvasRenderingContext2D.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	client/dom/generated/src/interface/CanvasRenderingContext2D.dart	View	2 chunks	+4 lines, -4 lines	1 comment	Download
M	client/dom/generated/src/wrapping/_CanvasRenderingContext2DWrappingImplementation.dart	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	client/dom/generated/wrapping_dom.js	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	client/dom/generated/wrapping_dom_externs.js	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	client/dom/scripts/dartgenerator.py	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	client/dom/scripts/template_monkey_dom.js	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	client/dom/scripts/template_monkey_dom_externs.js	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	client/dom/scripts/template_wrapping_dom.js	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	client/dom/scripts/template_wrapping_dom_externs.js	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

9 years, 1 month ago (2011-11-19 01:06:11 UTC) #2

LGTM if Object --> Dynamic

http://codereview.chromium.org/8595020/diff/1/client/dom/generated/src/interf...
File client/dom/generated/src/interface/CanvasRenderingContext2D.dart (right):

http://codereview.chromium.org/8595020/diff/1/client/dom/generated/src/interf...
client/dom/generated/src/interface/CanvasRenderingContext2D.dart:9: Object get
fillStyle();
I think 'any' should map to Dynamic.
People are just forced to write
context.fillStyle.dynamic.xxx

Expand Messages | Collapse Messages