aura: Popup windows too large to fit into the screen (or too small) gets opened in a tab instead.

aura: Popup windows too large to fit into the screen (or too small) gets opened in a tab instead.

ChromeOS with aura uses the normal BrowserView, and not chromeos::BrowserView,
so it is necessary to dup this logic in here.

BUG=103484
TEST=browser_tests:BrowserNavigatorTest.Disposition_LargePopup*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110755

[sky, 2011-11-18 20:21:05]

http://codereview.chromium.org/8595017/diff/1/chrome/browser/ui/views/frame/b...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/8595017/diff/1/chrome/browser/ui/views/frame/b...
chrome/browser/ui/views/frame/browser_view.cc:1300: gfx::Size size =
aura::Desktop::GetInstance()->GetHostSize();
Use screen instead.
Where was the code for this handled in chromeos before?

[sky, 2011-11-18 20:24:05]

One more question. This seems like weird behavior (forcing a popup to be a tab).
Any idea why we're doing this?

[sadrul, 2011-11-18 20:25:23]

On 2011/11/18 20:24:05, sky wrote:
> One more question. This seems like weird behavior (forcing a popup to be a
tab).
> Any idea why we're doing this?

I am not sure. The chromeos code is in
chrome/browser/chromeos/frame/browser_view.cc
(BrowserView::GetDispositionForPopupBounds). The comment in this CL is copied
verbatim from there.

[sadrul, 2011-11-18 20:29:24]

http://codereview.chromium.org/8595017/diff/1/chrome/browser/ui/views/frame/b...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/8595017/diff/1/chrome/browser/ui/views/frame/b...
chrome/browser/ui/views/frame/browser_view.cc:1300: gfx::Size size =
aura::Desktop::GetInstance()->GetHostSize();
On 2011/11/18 20:21:05, sky wrote:
> Use screen instead.
> Where was the code for this handled in chromeos before?

Done. (chrome/browser/chromeos/frame/browser_view.cc)

[sadrul, 2011-11-18 20:36:33]

On 2011/11/18 20:25:23, sadrul wrote:
> On 2011/11/18 20:24:05, sky wrote:
> > One more question. This seems like weird behavior (forcing a popup to be a
> tab).
> > Any idea why we're doing this?
> 
> I am not sure. The chromeos code is in
> chrome/browser/chromeos/frame/browser_view.cc
> (BrowserView::GetDispositionForPopupBounds). The comment in this CL is copied
> verbatim from there.

Reading the comment for the tests:

    // This test verifies that navigating to a large window with                
                                                                                
                            
    // WindowOpenDisposition = NEW_POPUP from a normal Browser results in a new
tab.

it sounds like this is a deliberate decision to do this on chromeos.

[sky, 2011-11-18 21:02:18]

LGTM