aura: Popup windows too large to fit into the screen (or too small) gets opened in a tab instead.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 91 matching lines @@
 #include "views/focus/view_storage.h"
 #include "views/layout/grid_layout.h"
 #include "views/widget/native_widget.h"
 #include "views/widget/root_view.h"
 #include "views/widget/widget.h"
 
 #if defined(USE_AURA)
 #include "chrome/browser/ui/views/accelerator_table.h"
 #include "chrome/browser/ui/views/aura/chrome_shell_delegate.h"
 #include "chrome/browser/ui/views/aura/launcher_icon_updater.h"
+#include "ui/aura/desktop.h"
 #include "ui/aura_shell/launcher/launcher.h"
 #include "ui/aura_shell/launcher/launcher_model.h"
 #include "ui/aura_shell/shell.h"
 #elif defined(OS_WIN)
 #include "chrome/browser/aeropeek_manager.h"
 #include "chrome/browser/jumplist_win.h"
 #include "ui/base/message_box_win.h"
 #include "views/widget/native_widget_win.h"
 #elif defined(TOOLKIT_USES_GTK)
 #include "chrome/browser/ui/views/accelerator_table.h"
@@ skipping 1163 matching lines @@
   delete preview_container_;
   preview_container_ = NULL;
 }
 
 gfx::Rect BrowserView::GetInstantBounds() {
   return contents_->GetPreviewBounds();
 }
 
 WindowOpenDisposition BrowserView::GetDispositionForPopupBounds(
     const gfx::Rect& bounds) {
+#if defined(USE_AURA) && defined(OS_CHROMEOS)
+  // If a popup is larger than a given fraction of the screen, turn it into
+  // a foreground tab. Also check for width or height == 0, which would
+  // indicate a tab sized popup window.
+  gfx::Size size = aura::Desktop::GetInstance()->GetHostSize();

[sky, 2011/11/18 20:21:05]

Use screen instead.
Where was the code for this handled in chromeos before?

[sadrul, 2011/11/18 20:29:25]

Done. (chrome/browser/chromeos/frame/browser_view.cc)

+  if (bounds.width() > size.width() ||
+      bounds.width() == 0 ||
+      bounds.height() > size.height() ||
+      bounds.height() == 0) {
+    return NEW_FOREGROUND_TAB;
+  }
+#endif
   return NEW_POPUP;
 }
 
 FindBar* BrowserView::CreateFindBar() {
   return browser::CreateFindBar(this);
 }
 
 #if defined(OS_CHROMEOS)
 void BrowserView::ShowMobileSetup() {
   MobileSetupDialog::Show();
@@ skipping 1299 matching lines @@
   Bubble::Show(this->GetWidget(), bounds, views::BubbleBorder::TOP_RIGHT,
                views::BubbleBorder::ALIGN_EDGE_TO_ANCHOR_EDGE,
                bubble_view, bubble_view);
 }
 
 void BrowserView::ShowAvatarBubbleFromAvatarButton() {
   AvatarMenuButton* button = frame_->GetAvatarMenuButton();
   if (button)
     button->ShowAvatarBubble();
 }