Add EINTR handling on ::close() calls in ppapi broker ui test.

Add EINTR handling on ::close() calls in ppapi broker ui test.

This change goes with r110241.

BUG=none
TEST=broker ui test passes


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111381

[xhwang, 2011-11-17 01:25:16]

Hello David,

Could you please review this change.  I also added a comment about whether to
use HANDLE_EINTR for mkstemp().

-xiaohan

http://codereview.chromium.org/8591008/diff/1/ppapi/tests/test_broker.cc
File ppapi/tests/test_broker.cc (right):

http://codereview.chromium.org/8591008/diff/1/ppapi/tests/test_broker.cc#newc...
ppapi/tests/test_broker.cc:145: int fd = ::mkstemp(file_name);
I saw examples of using HANDLE_EINTR for mkstemp() too:
http://www.google.com/codesearch#OAMlx_jo-ck/src/base/file_util_posix.cc&exac...

But from the documentation: http://linux.die.net/man/3/mkstemp, function
mkstemp() won't actually set EINTR.  Correct me if I am wrong.

[ddorwin, 2011-11-21 22:41:14]

lgtm

Need OWNERS approval.

http://codereview.chromium.org/8591008/diff/1/ppapi/tests/test_broker.cc
File ppapi/tests/test_broker.cc (right):

http://codereview.chromium.org/8591008/diff/1/ppapi/tests/test_broker.cc#newc...
ppapi/tests/test_broker.cc:145: int fd = ::mkstemp(file_name);
Maybe double check on Ubuntu's man page. I concur that it's not in that
documentation.

[xhwang, 2011-11-21 23:15:16]

http://codereview.chromium.org/8591008/diff/1/ppapi/tests/test_broker.cc
File ppapi/tests/test_broker.cc (right):

http://codereview.chromium.org/8591008/diff/1/ppapi/tests/test_broker.cc#newc...
ppapi/tests/test_broker.cc:145: int fd = ::mkstemp(file_name);
On 2011/11/21 22:41:14, ddorwin wrote:
> Maybe double check on Ubuntu's man page. I concur that it's not in that
> documentation.

Checked man page of Ubuntu and mkstemp doesn't trigger EINTR error.

http://manpages.ubuntu.com/manpages/precise/en/man3/mkstemp.3posix.html

[xhwang, 2011-11-21 23:19:07]

Hello piman and brettw,

Could you please do a OWNERS review.  It's a simple change that add HANDLE_EINTR
to a couple of operations.  Please also see the discussion about not adding
HANDLE_EINTR to mkstemp.

-xiaohan

[piman, 2011-11-21 23:23:45]

lgtm

http://codereview.chromium.org/8591008/diff/1/ppapi/tests/test_broker.cc
File ppapi/tests/test_broker.cc (right):

http://codereview.chromium.org/8591008/diff/1/ppapi/tests/test_broker.cc#newc...
ppapi/tests/test_broker.cc:145: int fd = ::mkstemp(file_name);
On 2011/11/21 23:15:16, xhwang wrote:
> On 2011/11/21 22:41:14, ddorwin wrote:
> > Maybe double check on Ubuntu's man page. I concur that it's not in that
> > documentation.
> 
> Checked man page of Ubuntu and mkstemp doesn't trigger EINTR error.
> 
> http://manpages.ubuntu.com/manpages/precise/en/man3/mkstemp.3posix.html

Usually, libc functions deal internally with the retries. Only for actual
syscall do we need to handle it explicitly.

[commit-bot: I haz the power, 2011-11-23 17:48:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/8591008/1

[commit-bot: I haz the power, 2011-11-23 18:57:22]

Change committed as 111381