Add EINTR handling on ::close() calls in ppapi broker ui test.

ppapi/tests/test_broker.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/tests/test_broker.h"
 
 #if defined(_MSC_VER)
 #define OS_WIN 1
 #include <windows.h>
 #else
@@ skipping 102 matching lines @@
   bool success = ReadMessage(file, message_len, message_received) &&
                  !::strcmp(message_received, message);
   delete [] message_received;
   return success;
 }
 
 bool ClosePlatformFile(PlatformFile file) {
 #if defined(OS_WIN)
   return !!::CloseHandle(file);
 #elif defined(OS_POSIX)
-  return !::close(file);
+  return !HANDLE_EINTR(::close(file));
 #endif
 }
 
 bool VerifyIsUnsandboxed() {
 #if defined(OS_WIN)
   FILE* file = NULL;
   wchar_t temp_path[MAX_PATH] = {'\0'};
   wchar_t file_name[MAX_PATH] = {'\0'};
   if (!::GetTempPath(MAX_PATH, temp_path) ||
       !::GetTempFileName(temp_path, L"test_pepper_broker", 0, file_name) ||
       ::_wfopen_s(&file, file_name, L"w"))
     return false;
 
   if (::fclose(file)) {
     ::DeleteFile(file_name);
     return false;
   }
 
   return !!::DeleteFile(file_name);
 #elif defined(OS_POSIX)
   char file_name[] = "/tmp/test_pepper_broker_XXXXXX";
   int fd = ::mkstemp(file_name);

[xhwang, 2011/11/17 01:25:16]

I saw examples of using HANDLE_EINTR for mkstemp() too:
http://www.google.com/codesearch#OAMlx_jo-ck/src/base/file_util_posix.cc&exac...

But from the documentation: http://linux.die.net/man/3/mkstemp, function
mkstemp() won't actually set EINTR.  Correct me if I am wrong.

[ddorwin, 2011/11/21 22:41:14]

Maybe double check on Ubuntu's man page. I concur that it's not in that
documentation.

[xhwang, 2011/11/21 23:15:16]

Checked man page of Ubuntu and mkstemp doesn't trigger EINTR error.

http://manpages.ubuntu.com/manpages/precise/en/man3/mkstemp.3posix.html

[piman, 2011/11/21 23:23:45]

Usually, libc functions deal internally with the retries. Only for actual
syscall do we need to handle it explicitly.

   if (-1 == fd)
     return false;
 
-  if (::close(fd)) {
+  if (HANDLE_EINTR(::close(fd))) {
     ::remove(file_name);
     return false;
   }
 
   return !::remove(file_name);
 #endif
 }
 
 // Callback in the broker when a new broker connection occurs.
 int32_t OnInstanceConnected(PP_Instance instance, int32_t handle) {
@@ skipping 121 matching lines @@
 
   PlatformFile file = IntToPlatformFile(handle);
   ASSERT_TRUE(VerifyMessage(file, sizeof(kHelloMessage), kHelloMessage));
   ASSERT_TRUE(VerifyMessage(file, sizeof(kBrokerUnsandboxed),
                             kBrokerUnsandboxed));
 
   ASSERT_TRUE(ClosePlatformFile(file));
 
   PASS();
 }