Issue 8590017: Fix "is Object" to always be true in Dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8590017: Fix "is Object" to always be true in Dart. (Closed)

Created:
9 years, 1 month ago by Jennifer Messerly

Modified:
9 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, mattsh

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix "is Object" to always be true in Dart. Also make sure our try-catch codegen knows this fact. This fixes: http://code.google.com/p/dart/issues/detail?id=469 Committed: https://code.google.com/p/dart/source/detail?r=1597

Patch Set 2 : fixed needsTemp path #

Patch Set 3 : frogsh and status #

Patch Set 4 : take2 after syncing #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -1128 lines)			Patch
M	frog/frogsh	View	1 2 3	15 chunks	+181 lines, -1114 lines	0 comments	Download
M	frog/gen.dart	View	1 2 3	4 chunks	+4 lines, -4 lines	0 comments	Download
M	frog/type.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	frog/value.dart	View	1 2 3	1 chunk	+9 lines, -4 lines	2 comments	Download
M	tests/co19/co19-frog.status	View	1 2 3	2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm http://codereview.chromium.org/8590017/diff/4001/frog/value.dart File frog/value.dart (right): http://codereview.chromium.org/8590017/diff/4001/frog/value.dart#newcode403 frog/value.dart:403: return new Value(world.nonNullBool, '($code, true)', span); can you ...

9 years, 1 month ago (2011-11-17 16:55:56 UTC) #2

Jennifer Messerly

9 years, 1 month ago (2011-11-17 18:18:51 UTC) #3

http://codereview.chromium.org/8590017/diff/4001/frog/value.dart
File frog/value.dart (right):

http://codereview.chromium.org/8590017/diff/4001/frog/value.dart#newcode403
frog/value.dart:403: return new Value(world.nonNullBool, '($code, true)', span);
On 2011/11/17 16:55:57, sigmund wrote:
> can you explain to me a bit more ($code, true)? is this so that we get the
side
> effects, then return true?

Yes, exactly.