chrome/installer/mini_installer.gyp - Issue 8589029: Start of mini_installer build config refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mini_installer.gyp

Issue 8589029: Start of mini_installer build config refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove packed_files.rc from mini_installer dependencies. It's used implicitly. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mini_installer.gyp

diff --git a/chrome/installer/mini_installer.gyp b/chrome/installer/mini_installer.gyp

index 4f73b983c868e1e3353eab0790dfc0507c07de45..9c99503662b3858b151f8b06a6bf5cde88c0a59b 100644

--- a/chrome/installer/mini_installer.gyp

+++ b/chrome/installer/mini_installer.gyp

@@ -22,7 +22,6 @@

'include_dirs': [

'../..',

- '<(PRODUCT_DIR)',

'<(INTERMEDIATE_DIR)',

'<(SHARED_INTERMEDIATE_DIR)/chrome',

@@ -209,13 +208,15 @@

'<(PRODUCT_DIR)/<(RULE_INPUT_NAME).7z',

'<(PRODUCT_DIR)/<(RULE_INPUT_NAME).packed.7z',

'<(PRODUCT_DIR)/setup.ex_',

- '<(PRODUCT_DIR)/packed_files.txt',

+ '<(INTERMEDIATE_DIR)/packed_files.rc',

'action': [

'python',

'<(create_installer_archive_py_path)',

- '--output_dir=<(PRODUCT_DIR)',

- '--input_file=<(RULE_INPUT_PATH)',

+ '--build_dir', '<(PRODUCT_DIR)',

+ '--staging_dir', '<(INTERMEDIATE_DIR)',

+ '--input_file', '<(RULE_INPUT_PATH)',

+ '--resource_file_path', '<(INTERMEDIATE_DIR)/packed_files.rc',

# TODO(sgk): may just use environment variables

#'--distribution=$(CHROMIUM_BUILD)',

'--distribution=_google_chrome',

« no previous file with comments | « no previous file | chrome/installer/mini_installer/mini_installer.rc » ('j') | no next file with comments »