Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 8589012: base::Bind fixes (Closed)

Created:
9 years, 1 month ago by groby-ooo-7-16
Modified:
9 years, 1 month ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

base::Bind fixes BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110554

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M chrome/browser/net/chrome_url_request_context.cc View 3 chunks +9 lines, -8 lines 1 comment Download
M chrome/browser/net/connection_tester.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/net/network_stats.h View 2 chunks +2 lines, -1 line 1 comment Download
M chrome/browser/net/network_stats.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/net/predictor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/predictor.cc View 2 chunks +4 lines, -3 lines 1 comment Download
M chrome/browser/net/sdch_dictionary_fetcher.h View 1 chunk +1 line, -1 line 1 comment Download
M chrome/browser/net/sdch_dictionary_fetcher.cc View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
groby-ooo-7-16
9 years, 1 month ago (2011-11-17 04:15:37 UTC) #1
wtc
LGTM. http://codereview.chromium.org/8589012/diff/1/chrome/browser/net/chrome_url_request_context.cc File chrome/browser/net/chrome_url_request_context.cc (right): http://codereview.chromium.org/8589012/diff/1/chrome/browser/net/chrome_url_request_context.cc#newcode168 chrome/browser/net/chrome_url_request_context.cc:168: &result)); Nit: align all the function arguments of ...
9 years, 1 month ago (2011-11-17 08:16:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8589012/1
9 years, 1 month ago (2011-11-17 19:38:02 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 21:18:26 UTC) #4
Change committed as 110554

Powered by Google App Engine
This is Rietveld 408576698