base::Bind fixes

chrome/browser/net/sdch_dictionary_fetcher.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Support modularity by calling to load a new SDCH filter dictionary.
 // Note that this sort of calling can't be done in the /net directory, as it has
 // no concept of the HTTP cache (which is only visible at the browser level).
 
 #ifndef CHROME_BROWSER_NET_SDCH_DICTIONARY_FETCHER_H_
 #define CHROME_BROWSER_NET_SDCH_DICTIONARY_FETCHER_H_
@@ skipping 41 matching lines @@
   // completes (either successfully or with failure).
   virtual void OnURLFetchComplete(const content::URLFetcher* source) OVERRIDE;
 
   // A queue of URLs that are being used to download dictionaries.
   std::queue<GURL> fetch_queue_;
   // The currently outstanding URL fetch of a dicitonary.
   // If this is null, then there is no outstanding request.
   scoped_ptr<content::URLFetcher> current_fetch_;
 
   // Always spread out the dictionary fetches, so that they don't steal
   // bandwidth from the actual page load.  Create delayed tasks to spread out

[wtc, 2011/11/17 08:16:21]

Is this comment still accurate?  Does weak_factory_ still
create delayed tasks?

   // the download.
-  ScopedRunnableMethodFactory<SdchDictionaryFetcher> method_factory_;
+  base::WeakPtrFactory<SdchDictionaryFetcher> weak_factory_;
   bool task_is_pending_;
 
   // Althought the SDCH spec does not preclude a server from using a single URL
   // to load several distinct dictionaries (by telling a client to load a
   // dictionary from an URL several times), current implementations seem to have
   // that 1-1 relationship (i.e., each URL points at a single dictionary, and
   // the dictionary content does not change over time, and hence is not worth
   // trying to load more than once).  In addition, some dictionaries prove
   // unloadable only after downloading them (because they are too large?  ...or
   // malformed?). As a protective element, Chromium will *only* load a
   // dictionary at most once from a given URL (so that it doesn't waste
   // bandwidth trying repeatedly).
   // The following set lists all the dictionary URLs that we've tried to load,
   // so that we won't try to load from an URL more than once.
   // TODO(jar): Try to augment the SDCH proposal to include this restiction.
   std::set<GURL> attempted_load_;
 
   DISALLOW_COPY_AND_ASSIGN(SdchDictionaryFetcher);
 };
 
 #endif  // CHROME_BROWSER_NET_SDCH_DICTIONARY_FETCHER_H_