Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 8589005: Remove NaCl file from ppapi_geturl test. (Closed)

Created:
9 years, 1 month ago by nfullagar
Modified:
9 years ago
Reviewers:
polina, sehr
CC:
chromium-reviews
Visibility:
Public.

Description

Remove NaCl file from ppapi_geturl test. BUG= none TEST= ppapi_geturl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111845

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -281 lines) Patch
M ppapi/native_client/tests/ppapi_geturl/build.scons View 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/native_client/tests/ppapi_geturl/module.cc View 2 chunks +1 line, -43 lines 0 comments Download
M ppapi/native_client/tests/ppapi_geturl/nacl.scons View 3 chunks +2 lines, -9 lines 0 comments Download
D ppapi/native_client/tests/ppapi_geturl/nacl_file_main.h View 1 chunk +0 lines, -10 lines 0 comments Download
D ppapi/native_client/tests/ppapi_geturl/nacl_file_main.cc View 1 chunk +0 lines, -214 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nfullagar
9 years, 1 month ago (2011-11-17 01:26:13 UTC) #1
polina
LGTM (if trybots are happy)
9 years, 1 month ago (2011-11-18 08:32:15 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-28 23:34:20 UTC) #3
sehr
lgtm
9 years ago (2011-11-29 01:00:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/8589005/4001
9 years ago (2011-11-29 01:01:06 UTC) #5
commit-bot: I haz the power
9 years ago (2011-11-29 02:46:07 UTC) #6
Change committed as 111845

Powered by Google App Engine
This is Rietveld 408576698