GTK: Create the start of a compatibility header wrapping deprecated methods.

GTK: Create the start of a compatibility header wrapping deprecated methods.

GTK 2.24 deprecated all sorts of raw access to object internals in preparation
for GTK3.

BUG=79722
TEST=compiles
TBR=tony,jam

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111065

[Elliot Glaysher, 2011-11-21 18:48:21]

whoever gets to it first.

[Lei Zhang, 2011-11-21 22:41:22]

lgtm

[commit-bot: I haz the power, 2011-11-21 23:17:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8588068/3001

[commit-bot: I haz the power, 2011-11-21 23:17:24]

Presubmit check for 8588068-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
ui/base/gtk/gtk_floating_container.cc,content/browser/tab_contents/web_drag_source_gtk.cc,webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc,webkit/tools/test_shell/test_shell_gtk.cc,webkit/plugins/npapi/gtk_plugin_container_manager.cc,content/browser/renderer_host/gtk_window_utils.cc,ui/base/gtk/gtk_expanded_container.cc,ui/base/gtk/gtk_compat.h,ui/gfx/gtk_native_view_id_manager.cc,ui/base/gtk/gtk_windowing.cc,ui/gfx/gtk_preserve_window.cc,content/browser/renderer_host/render_widget_host_view_gtk.cc

Presubmit checks took 4.4s to calculate.

[Elliot Glaysher, 2011-11-21 23:20:16]

sky or ben: Please stamp for ui/base/gtk/. The only change is adding a
compatibility header that declares equivalents for methods in newer versions of
gtk and will be used during the removal of deprecated methods and raw access.

[sky, 2011-11-21 23:38:54]

LGTM
How about a patch that creates OWNERS file in ui/base/gtk with you and estade in
it?

[commit-bot: I haz the power, 2011-11-21 23:42:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8588068/3001

[commit-bot: I haz the power, 2011-11-21 23:42:36]

Presubmit check for 8588068-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
webkit/tools/test_shell/test_shell_gtk.cc,webkit/plugins/npapi/gtk_plugin_container_manager.cc,webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc

Presubmit checks took 3.3s to calculate.

[Elliot Glaysher, 2011-11-21 23:47:41]

TBR tony and jam: one line changes from C_MACROS to equivalent real acessor
functions.

[commit-bot: I haz the power, 2011-11-21 23:47:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/8588068/3001

[tony, 2011-11-21 23:58:46]

LGTM

[commit-bot: I haz the power, 2011-11-22 01:17:33]

Change committed as 111065

[jam, 2011-11-22 01:17:57]

content lgtm