chrome/browser/ui/gtk/bubble/bubble_gtk.cc - Issue 8588068: GTK: Create the start of a compatibility header wrapping deprecated methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bubble/bubble_gtk.cc

Issue 8588068: GTK: Create the start of a compatibility header wrapping deprecated methods. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase to ToT and remove views/ cleanups. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/gtk/bubble/bubble_gtk.cc

diff --git a/chrome/browser/ui/gtk/bubble/bubble_gtk.cc b/chrome/browser/ui/gtk/bubble/bubble_gtk.cc

index 089dae68a49a4fa237a3121e5ca6bb49311974e3..4af8597ce2574cba7e5309daabacf23968ad168d 100644

--- a/chrome/browser/ui/gtk/bubble/bubble_gtk.cc

+++ b/chrome/browser/ui/gtk/bubble/bubble_gtk.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/ui/gtk/gtk_util.h"

#include "chrome/common/chrome_notification_types.h"

#include "content/public/browser/notification_source.h"

+#include "ui/base/gtk/gtk_compat.h"

#include "ui/base/gtk/gtk_hig_constants.h"

#include "ui/base/gtk/gtk_windowing.h"

#include "ui/gfx/gtk_util.h"

@@ -100,7 +101,7 @@ void BubbleGtk::Init(GtkWidget* anchor_widget,

DCHECK(!window_);

anchor_widget_ = anchor_widget;

toplevel_window_ = GTK_WINDOW(gtk_widget_get_toplevel(anchor_widget_));

- DCHECK(GTK_WIDGET_TOPLEVEL(toplevel_window_));

+ DCHECK(gtk_widget_is_toplevel(GTK_WIDGET(toplevel_window_)));

rect_ = rect ? *rect : gtk_util::WidgetBounds(anchor_widget);

preferred_arrow_location_ = arrow_location;

« no previous file with comments | « chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc ('k') | chrome/browser/ui/gtk/constrained_window_gtk.cc » ('j') | no next file with comments »