Issue 8588064: views: Move bubble, events, focus and layout to ui/views/.

Issue 8588064: views: Move bubble, events, focus and layout to ui/views/. (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa, msw+watch_chromium.org, alicet1, tfarina, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Move bubble, events, focus and layout to ui/views/. Left stub files that will be removed in a follow up patch after updating the files to point to the new location. BUG=104039 R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110761

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -9272 lines)			Patch
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	ui/views/bubble/border_contents_view.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/bubble/border_contents_view.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/bubble/bubble_border.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/bubble/bubble_border.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/bubble/bubble_delegate.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/bubble/bubble_delegate.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/bubble/bubble_delegate_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/bubble/bubble_frame_view.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/bubble/bubble_frame_view.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/bubble/bubble_frame_view_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/events/event.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/events/event.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/events/event_aura.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/events/event_gtk.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/events/event_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/events/event_wayland.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/events/event_win.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/events/event_x.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/accelerator_handler.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/focus/accelerator_handler_aura.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/accelerator_handler_gtk.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/accelerator_handler_gtk_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/accelerator_handler_touch.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/accelerator_handler_wayland.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/accelerator_handler_win.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/external_focus_tracker.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/focus/external_focus_tracker.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/focus_manager.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/focus/focus_manager.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/focus_manager_factory.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/focus/focus_manager_factory.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/focus_manager_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/focus/focus_search.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/focus/focus_search.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	ui/views/focus/view_storage.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/focus/view_storage.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	ui/views/focus/widget_focus_manager.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/focus/widget_focus_manager.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/layout/box_layout.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/layout/box_layout.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/layout/box_layout_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/layout/fill_layout.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/layout/fill_layout.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/layout/grid_layout.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/layout/grid_layout.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/layout/grid_layout_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	ui/views/layout/layout_constants.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/layout/layout_manager.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	ui/views/layout/layout_manager.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	views/bubble/border_contents_view.h	View		1 chunk	+2 lines, -78 lines	0 comments	Download
D	views/bubble/border_contents_view.cc	View		1 chunk	+0 lines, -185 lines	0 comments	Download
M	views/bubble/bubble_border.h	View		1 chunk	+2 lines, -173 lines	0 comments	Download
D	views/bubble/bubble_border.cc	View		1 chunk	+0 lines, -511 lines	0 comments	Download
M	views/bubble/bubble_delegate.h	View		1 chunk	+2 lines, -143 lines	0 comments	Download
D	views/bubble/bubble_delegate.cc	View		1 chunk	+0 lines, -287 lines	0 comments	Download
D	views/bubble/bubble_delegate_unittest.cc	View		1 chunk	+0 lines, -31 lines	0 comments	Download
M	views/bubble/bubble_frame_view.h	View		1 chunk	+2 lines, -47 lines	0 comments	Download
D	views/bubble/bubble_frame_view.cc	View		1 chunk	+0 lines, -78 lines	0 comments	Download
D	views/bubble/bubble_frame_view_unittest.cc	View		1 chunk	+0 lines, -68 lines	0 comments	Download
M	views/events/event.h	View		1 chunk	+2 lines, -405 lines	0 comments	Download
D	views/events/event.cc	View		1 chunk	+0 lines, -200 lines	0 comments	Download
D	views/events/event_aura.cc	View		1 chunk	+0 lines, -62 lines	0 comments	Download
D	views/events/event_gtk.cc	View		1 chunk	+0 lines, -183 lines	0 comments	Download
D	views/events/event_unittest.cc	View		1 chunk	+0 lines, -128 lines	0 comments	Download
D	views/events/event_wayland.cc	View		1 chunk	+0 lines, -23 lines	0 comments	Download
D	views/events/event_win.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download
D	views/events/event_x.cc	View		1 chunk	+0 lines, -152 lines	0 comments	Download
M	views/focus/accelerator_handler.h	View		1 chunk	+2 lines, -51 lines	0 comments	Download
D	views/focus/accelerator_handler_aura.cc	View		1 chunk	+0 lines, -29 lines	0 comments	Download
D	views/focus/accelerator_handler_gtk.cc	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	views/focus/accelerator_handler_gtk_unittest.cc	View		1 chunk	+0 lines, -199 lines	0 comments	Download
D	views/focus/accelerator_handler_touch.cc	View		1 chunk	+0 lines, -187 lines	0 comments	Download
D	views/focus/accelerator_handler_wayland.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download
D	views/focus/accelerator_handler_win.cc	View		1 chunk	+0 lines, -60 lines	0 comments	Download
	views/focus/external_focus_tracker.h	View		1 chunk	+2 lines, -68 lines	0 comments	Download
D	views/focus/external_focus_tracker.cc	View		1 chunk	+0 lines, -72 lines	0 comments	Download
M	views/focus/focus_manager.h	View		1 chunk	+2 lines, -273 lines	0 comments	Download
D	views/focus/focus_manager.cc	View		1 chunk	+0 lines, -413 lines	0 comments	Download
M	views/focus/focus_manager_factory.h	View		1 chunk	+2 lines, -31 lines	0 comments	Download
D	views/focus/focus_manager_factory.cc	View		1 chunk	+0 lines, -55 lines	0 comments	Download
D	views/focus/focus_manager_unittest.cc	View		1 chunk	+0 lines, -1763 lines	0 comments	Download
M	views/focus/focus_search.h	View		1 chunk	+5 lines, -115 lines	0 comments	Download
D	views/focus/focus_search.cc	View		1 chunk	+0 lines, -272 lines	0 comments	Download
M	views/focus/view_storage.h	View		1 chunk	+2 lines, -60 lines	0 comments	Download
D	views/focus/view_storage.cc	View		1 chunk	+0 lines, -115 lines	0 comments	Download
M	views/focus/widget_focus_manager.h	View		1 chunk	+2 lines, -72 lines	0 comments	Download
D	views/focus/widget_focus_manager.cc	View		1 chunk	+0 lines, -50 lines	0 comments	Download
M	views/layout/box_layout.h	View		1 chunk	+3 lines, -53 lines	0 comments	Download
D	views/layout/box_layout.cc	View		1 chunk	+0 lines, -76 lines	0 comments	Download
D	views/layout/box_layout_unittest.cc	View		1 chunk	+0 lines, -111 lines	0 comments	Download
M	views/layout/fill_layout.h	View		1 chunk	+2 lines, -26 lines	0 comments	Download
D	views/layout/fill_layout.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download
M	views/layout/grid_layout.h	View		1 chunk	+2 lines, -361 lines	0 comments	Download
D	views/layout/grid_layout.cc	View		1 chunk	+0 lines, -1070 lines	0 comments	Download
D	views/layout/grid_layout_unittest.cc	View		1 chunk	+0 lines, -606 lines	0 comments	Download
M	views/layout/layout_constants.h	View		1 chunk	+2 lines, -61 lines	0 comments	Download
M	views/layout/layout_manager.h	View		1 chunk	+5 lines, -54 lines	0 comments	Download
D	views/layout/layout_manager.cc	View		1 chunk	+0 lines, -30 lines	0 comments	Download
M	views/views.gyp	View		14 chunks	+60 lines, -60 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 1 month ago (2011-11-18 20:25:19 UTC) #2

lgtm

http://codereview.chromium.org/8588064/diff/2001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/8588064/diff/2001/chrome/chrome_tests.gypi#new...
chrome/chrome_tests.gypi:2187:
'../ui/views/focus/accelerator_handler_gtk_unittest.cc',
I suspect this line is no longer required.

Expand Messages | Collapse Messages