Remove "open in new tab" items from context menu if the process doesn't

chrome/browser/browser_process_impl.cc

Index: chrome/browser/browser_process_impl.cc
===================================================================
--- chrome/browser/browser_process_impl.cc	(revision 112335)
+++ chrome/browser/browser_process_impl.cc	(working copy)
@@ -146,8 +146,11 @@
 
   net_log_.reset(new ChromeNetLog);
 
-  ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeScheme(
-      chrome::kExtensionScheme);
+  ChildProcessSecurityPolicy* policy =
+      ChildProcessSecurityPolicy::GetInstance();
+  policy->RegisterWebSafeScheme(chrome::kExtensionScheme);
+  policy->RegisterWebSafeScheme(chrome::kChromeDevToolsScheme);

[abarth-chromium, 2011/12/01 00:22:35]

Why is dev tools web-safe?  You shouldn't be able to follow hyperlinks into the
inspector.  That would be strange.

[Tom Sepez, 2011/12/01 00:43:36]

Looks like this is in response to breaking the devtools.  Will remove this and
retest.

+  policy->RegisterPseudoScheme(chrome::kChromeUIScheme);

[abarth-chromium, 2011/12/01 00:22:35]

Why is ChromeUIScheme a pseudo scheme?  That doesn't seem right.

[Tom Sepez, 2011/12/01 00:43:36]

This has to do with ChildProcessSecurityPolicy::CanRequestURL() and its
overzealous desire to conclude that URLs are destined for the shell if
!net::URLRequest::IsHandledURL(url).  We change this to conclude that shell
requests also aren't pseudo-schemes, and add chrome to that list.  chrome smells
like a pseudo scheme if its not being handled by URLRequest, no?

 
   extension_event_router_forwarder_ = new ExtensionEventRouterForwarder;