Remove "open in new tab" items from context menu if the process doesn't

chrome/browser/browser_process_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_process_impl.h"
 
 #include <map>
 #include <set>
 #include <vector>
 
@@ skipping 128 matching lines @@
       thumbnail_generator_(new ThumbnailGenerator),
       download_status_updater_(new DownloadStatusUpdater) {
   g_browser_process = this;
   clipboard_.reset(new ui::Clipboard);
 
   // Must be created after the NotificationService.
   print_job_manager_.reset(new printing::PrintJobManager);
 
   net_log_.reset(new ChromeNetLog);
 
-  ChildProcessSecurityPolicy::GetInstance()->RegisterWebSafeScheme(
-      chrome::kExtensionScheme);
+  ChildProcessSecurityPolicy* policy =
+      ChildProcessSecurityPolicy::GetInstance();
+  policy->RegisterWebSafeScheme(chrome::kExtensionScheme);
+  policy->RegisterWebSafeScheme(chrome::kChromeDevToolsScheme);

[abarth-chromium, 2011/12/01 00:22:35]

Why is dev tools web-safe?  You shouldn't be able to follow hyperlinks into the
inspector.  That would be strange.

[Tom Sepez, 2011/12/01 00:43:36]

Looks like this is in response to breaking the devtools.  Will remove this and
retest.

+  policy->RegisterPseudoScheme(chrome::kChromeUIScheme);

[abarth-chromium, 2011/12/01 00:22:35]

Why is ChromeUIScheme a pseudo scheme?  That doesn't seem right.

[Tom Sepez, 2011/12/01 00:43:36]

This has to do with ChildProcessSecurityPolicy::CanRequestURL() and its
overzealous desire to conclude that URLs are destined for the shell if
!net::URLRequest::IsHandledURL(url).  We change this to conclude that shell
requests also aren't pseudo-schemes, and add chrome to that list.  chrome smells
like a pseudo scheme if its not being handled by URLRequest, no?

 
   extension_event_router_forwarder_ = new ExtensionEventRouterForwarder;
 
   ExtensionTabIdMap::GetInstance()->Init();
 
   online_state_observer_.reset(new BrowserOnlineStateObserver);
 }
 
 BrowserProcessImpl::~BrowserProcessImpl() {
   // See StartTearDown and PreStopThread functions below, this is where
@@ skipping 847 matching lines @@
 }
 
 void BrowserProcessImpl::OnAutoupdateTimer() {
   if (CanAutorestartForUpdate()) {
     DLOG(WARNING) << "Detected update.  Restarting browser.";
     RestartBackgroundInstance();
   }
 }
 
 #endif  // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)