Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 8588003: Add a new field trial for Instant. (Closed)

Created:
9 years, 1 month ago by sreeram
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, Paweł Hajdan Jr., arvind_google.com
Visibility:
Public.

Description

Add a new field trial for Instant. The new field trial (SUGGEST) is almost the same as HIDDEN, except that the Instant suggested text is allowed to be autocompleted into the omnibox. Since the hidden tab contains results for the full query, it's more likely to be relevant when the user presses <Enter>. From the user perspective, the omnibox autocompletion is similar to how it behaves for past searches. BUG=none TEST=With --instant-field-trial=suggest, type into the omnibox, and observe that it gets inline autocompleted, even though there's no Instant preview. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -8 lines) Patch
M chrome/browser/instant/instant_browsertest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/instant/instant_field_trial.h View 4 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/instant/instant_field_trial.cc View 9 chunks +45 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sreeram
Please review.
9 years, 1 month ago (2011-11-16 22:21:02 UTC) #1
Peter Kasting
Deferring to sky.
9 years, 1 month ago (2011-11-16 22:22:56 UTC) #2
sky
Are we close to running out of possible permutations to try? :) LGTM
9 years, 1 month ago (2011-11-16 22:25:01 UTC) #3
sreeram
On 2011/11/16 22:25:01, sky wrote: > Are we close to running out of possible permutations ...
9 years, 1 month ago (2011-11-16 23:10:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sreeram@chromium.org/8588003/1
9 years, 1 month ago (2011-11-17 05:15:54 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 06:52:46 UTC) #6
Change committed as 110463

Powered by Google App Engine
This is Rietveld 408576698