Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2833)

Unified Diff: chrome/browser/instant/instant_field_trial.h

Issue 8588003: Add a new field trial for Instant. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/instant/instant_field_trial.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_field_trial.h
diff --git a/chrome/browser/instant/instant_field_trial.h b/chrome/browser/instant/instant_field_trial.h
index 52765d557055271a02dc9502e42a5de84f1577cf..5e2b3f8775853a821927190ae4d40e88b635d48c 100644
--- a/chrome/browser/instant/instant_field_trial.h
+++ b/chrome/browser/instant/instant_field_trial.h
@@ -28,11 +28,15 @@ class Profile;
//
// HIDDEN_EXPERIMENT: Queries are issued as the user types, but no preview is
// shown until they press <Enter>. If the user hasn't opted to send metrics
-// (UMA) data, they are bounced back to INACTIVE.
+// (UMA) data, they are bounced back to INACTIVE. Suggestions obtained from
+// Instant are not propagated back to the omnibox.
//
// SILENT_EXPERIMENT: No queries are issued until the user presses <Enter>. No
// previews are shown. The user is not required to send metrics (UMA) data.
//
+// SUGGEST_EXPERIMENT: Same as HIDDEN, except that the Instant suggestions are
+// autocompleted inline into the omnibox.
+//
// UMA_CONTROL: Instant is disabled. If the user hasn't opted to send metrics
// (UMA) data, they are bounced back to INACTIVE.
//
@@ -51,13 +55,19 @@ class InstantFieldTrial {
INSTANT_EXPERIMENT_A,
INSTANT_EXPERIMENT_B,
+
HIDDEN_EXPERIMENT_A,
HIDDEN_EXPERIMENT_B,
+
SILENT_EXPERIMENT_A,
SILENT_EXPERIMENT_B,
+ SUGGEST_EXPERIMENT_A,
+ SUGGEST_EXPERIMENT_B,
+
UMA_CONTROL_A,
UMA_CONTROL_B,
+
ALL_CONTROL_A,
ALL_CONTROL_B,
};
@@ -72,7 +82,7 @@ class InstantFieldTrial {
// Check if the user is in any of the EXPERIMENT groups.
static bool IsInstantExperiment(Profile* profile);
- // Check if the user is in the HIDDEN or SILENT EXPERIMENT groups.
+ // Check if the user is in the HIDDEN, SILENT or SUGGEST EXPERIMENT groups.
static bool IsHiddenExperiment(Profile* profile);
// Check if the user is in the SILENT EXPERIMENT group.
@@ -85,6 +95,10 @@ class InstantFieldTrial {
// Returns a string denoting the user's group, for adding as a URL param.
static std::string GetGroupAsUrlParam(Profile* profile);
+ // Returns whether the Instant suggested text should be autocompleted inline
+ // into the omnibox.
+ static bool ShouldSetSuggestedText(Profile* profile);
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(InstantFieldTrial);
};
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/instant/instant_field_trial.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698