Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 8586050: Revert 110684 - Protector strings and bubble/SettingsChange code refactoring. (Closed)

Created:
9 years, 1 month ago by Ivan Korotkov
Modified:
9 years, 1 month ago
Reviewers:
Ivan Korotkov
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 110684 - Protector strings and bubble/SettingsChange code refactoring. BUG=102765, 103317 TEST=Manual Review URL: http://codereview.chromium.org/8590036 TBR=ivankr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -251 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +33 lines, -33 lines 0 comments Download
M chrome/browser/protector/default_search_provider_change.cc View 3 chunks +43 lines, -138 lines 0 comments Download
M chrome/browser/protector/protector.h View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/protector/protector.cc View 2 chunks +15 lines, -23 lines 0 comments Download
M chrome/browser/protector/setting_change.h View 1 chunk +29 lines, -23 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error.h View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error.cc View 4 chunks +80 lines, -15 lines 0 comments Download
M chrome/browser/protector/settings_change_global_error_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ivan Korotkov
9 years, 1 month ago (2011-11-18 13:09:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698