Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: chrome/browser/protector/protector.h

Issue 8586050: Revert 110684 - Protector strings and bubble/SettingsChange code refactoring. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/protector/default_search_provider_change.cc ('k') | chrome/browser/protector/protector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/protector/protector.h
===================================================================
--- chrome/browser/protector/protector.h (revision 110688)
+++ chrome/browser/protector/protector.h (working copy)
@@ -21,8 +21,9 @@
class SettingsChangeGlobalError;
-// Presents a SettingChange to user and handles possible user actions.
-// Deletes itself after a user action is taken or timeout expires.
+// Accumulates settings changes and shows them altogether to user.
+// Deletes itself when changes are shown to the user and some action is taken
+// or timeout expires.
class Protector : public SettingsChangeGlobalErrorDelegate {
public:
explicit Protector(Profile* profile);
@@ -36,12 +37,12 @@
TemplateURLService* GetTemplateURLService();
// Shows global error about the specified change. Ownership of the change
- // is passed to the GlobalError object.
+ // is passed to the error object.
void ShowChange(SettingChange* change);
// SettingsChangeGlobalErrorDelegate implementation.
- virtual void OnApplyChange() OVERRIDE;
- virtual void OnDiscardChange() OVERRIDE;
+ virtual void OnApplyChanges() OVERRIDE;
+ virtual void OnDiscardChanges() OVERRIDE;
virtual void OnDecisionTimeout() OVERRIDE;
virtual void OnRemovedFromProfile() OVERRIDE;
@@ -51,10 +52,9 @@
// The object can only be allocated and destroyed on heap.
virtual ~Protector();
- // Performs the initial action on settings change and shows it. This is run
- // asynchronously on UI thread because |ShowChange| may be called in the
- // middle of some operations on settings that have changed.
- void InitAndShowChange(SettingChange* change);
+ // Common handler for error delegate handlers. Calls the specified method
+ // on each change we showed error for.
+ void OnChangesAction(SettingChangeAction action);
// Pointer to error bubble controller. Indicates if we're showing change
// notification to user. Owns itself.
« no previous file with comments | « chrome/browser/protector/default_search_provider_change.cc ('k') | chrome/browser/protector/protector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698