Add extension API to change window show state using chrome.windows.update().

chrome/browser/extensions/extension_tabs_apitest.cc

Index: chrome/browser/extensions/extension_tabs_apitest.cc
diff --git a/chrome/browser/extensions/extension_tabs_apitest.cc b/chrome/browser/extensions/extension_tabs_apitest.cc
index c0e4f0e984e7fb03c57b2d9544243b4e031ee29e..bff8fb84b45e15ce8277a807d9ff4bb4bc11aa7c 100644
--- a/chrome/browser/extensions/extension_tabs_apitest.cc
+++ b/chrome/browser/extensions/extension_tabs_apitest.cc
@@ -26,9 +26,12 @@
   DISABLED_FocusWindowDoesNotExitFullscreen
 #define MAYBE_UpdateWindowSizeExitsFullscreen \
   DISABLED_UpdateWindowSizeExitsFullscreen
+#define MAYBE_UpdateWindowShowState \
+  DISABLED_UpdateWindowShowState

[asargent_no_longer_on_chrome, 2011/11/18 18:52:24]

:(

It's a bummer to add a new test that starts out disabled.  Can we fix the test
to work in all platforms?

Actually, an interesting alternative for this might be to rewrite all these
tests (or at least the test of your new properties / params) using our
relatively new chrome/browser/extensions/extension_function_test_utils.h stuff -
see that file and the small number of new tests that we've written using it. 

[jennb, 2011/11/19 01:44:33]

I tried using the extension_function_test_utils.h stuff to invoke the state
changes, but even after a message loop RunAllPending, the state wasn't updated
on linux yet. Manual verification shows the window does change state. I ended up
leaving the existing test alone. On the bright side, I added more tests using
extension_function_test_utils.h stuff to check the invalid cases. 

 #else
 #define MAYBE_FocusWindowDoesNotExitFullscreen FocusWindowDoesNotExitFullscreen
 #define MAYBE_UpdateWindowSizeExitsFullscreen UpdateWindowSizeExitsFullscreen
+#define MAYBE_UpdateWindowShowState UpdateWindowShowState
 #endif
 
 // In the touch build, this fails reliably. http://crbug.com/85191
@@ -205,6 +208,10 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FocusWindowDoesNotUnmaximize) {
 }
 #endif  // OS_WIN
 
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_UpdateWindowShowState) {
+  ASSERT_TRUE(RunExtensionTest("window_update/show_state")) << message_;
+}
+
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoDisabledByPref) {
   IncognitoModePrefs::SetAvailability(browser()->profile()->GetPrefs(),
                                       IncognitoModePrefs::DISABLED);