Add extension API to change window show state using chrome.windows.update().

chrome/browser/extensions/extension_tabs_apitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_apitest.h"
 
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/common/pref_names.h"
 #include "net/base/mock_host_resolver.h"
 
 // Possible race in ChromeURLDataManager. http://crbug.com/59198
 #if defined(OS_MACOSX) || defined(OS_LINUX)
 #define MAYBE_TabOnRemoved DISABLED_TabOnRemoved
 #else
 #define MAYBE_TabOnRemoved TabOnRemoved
 #endif
 
 // Window resizes are not completed by the time the callback happens,
 // so these tests fail on linux. http://crbug.com/72369
 #if defined(OS_LINUX)
 #define MAYBE_FocusWindowDoesNotExitFullscreen \
   DISABLED_FocusWindowDoesNotExitFullscreen
 #define MAYBE_UpdateWindowSizeExitsFullscreen \
   DISABLED_UpdateWindowSizeExitsFullscreen
+#define MAYBE_UpdateWindowShowState \
+  DISABLED_UpdateWindowShowState

[asargent_no_longer_on_chrome, 2011/11/18 18:52:24]

:(

It's a bummer to add a new test that starts out disabled.  Can we fix the test
to work in all platforms?

Actually, an interesting alternative for this might be to rewrite all these
tests (or at least the test of your new properties / params) using our
relatively new chrome/browser/extensions/extension_function_test_utils.h stuff -
see that file and the small number of new tests that we've written using it. 

[jennb, 2011/11/19 01:44:33]

I tried using the extension_function_test_utils.h stuff to invoke the state
changes, but even after a message loop RunAllPending, the state wasn't updated
on linux yet. Manual verification shows the window does change state. I ended up
leaving the existing test alone. On the bright side, I added more tests using
extension_function_test_utils.h stuff to check the invalid cases. 

 #else
 #define MAYBE_FocusWindowDoesNotExitFullscreen FocusWindowDoesNotExitFullscreen
 #define MAYBE_UpdateWindowSizeExitsFullscreen UpdateWindowSizeExitsFullscreen
+#define MAYBE_UpdateWindowShowState UpdateWindowShowState
 #endif
 
 // In the touch build, this fails reliably. http://crbug.com/85191
 #if defined(TOUCH_UI)
 #define MAYBE_GetViewsOfCreatedWindow DISABLED_GetViewsOfCreatedWindow
 #else
 #define MAYBE_GetViewsOfCreatedWindow GetViewsOfCreatedWindow
 #endif
 
 // In the touch build, this fails unreliably. http://crbug.com/85226
@@ skipping 156 matching lines @@
 
 #if defined(OS_WIN) && !defined(USE_AURA)
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FocusWindowDoesNotUnmaximize) {
   gfx::NativeWindow window = browser()->window()->GetNativeHandle();
   ::SendMessage(window, WM_SYSCOMMAND, SC_MAXIMIZE, 0);
   ASSERT_TRUE(RunExtensionTest("window_update/focus")) << message_;
   ASSERT_TRUE(::IsZoomed(window));
 }
 #endif  // OS_WIN
 
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_UpdateWindowShowState) {
+  ASSERT_TRUE(RunExtensionTest("window_update/show_state")) << message_;
+}
+
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoDisabledByPref) {
   IncognitoModePrefs::SetAvailability(browser()->profile()->GetPrefs(),
                                       IncognitoModePrefs::DISABLED);
 
   // This makes sure that creating an incognito window fails due to pref
   // (policy) being set.
   ASSERT_TRUE(RunExtensionTest("tabs/incognito_disabled")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedPopup) {
   ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_popup.html"))
       << message_;
 }
 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_GetViewsOfCreatedWindow) {
   ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))
       << message_;
 }
 
 // Adding a new test? Awesome. But API tests are the old hotness. The
 // new hotness is extension_test_utils. See extension_tabs_test.cc for
 // an example. We are trying to phase out many uses of API tests as
 // they tend to be flaky.