Issue 8586042: Revert 110555 - sync: Remove ModelNeutralExecuteImpl()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8586042: Revert 110555 - sync: Remove ModelNeutralExecuteImpl() (Closed)

Created:
9 years, 1 month ago by rlarocque

Modified:
9 years, 1 month ago

Reviewers:
rlarocque

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 110555 - sync: Remove ModelNeutralExecuteImpl() ProcessUpdatesCommand was the only child of ModelChangingSyncerCommand to override this function. Since it is special, let's just treat it specially in syncer.cc rather than modifying ModelChangingSyncerCommand to suit its needs. BUG=36594 TEST= Review URL: http://codereview.chromium.org/8510079 TBR=rlarocque@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110572

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -11 lines)			Patch
M	chrome/browser/sync/engine/model_changing_syncer_command.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/model_changing_syncer_command.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/process_updates_command.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/process_updates_command.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/sessions/status_controller.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/sessions/status_controller.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 1 (0 generated)