Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1518)

Unified Diff: chrome/browser/sync/engine/model_changing_syncer_command.h

Issue 8586042: Revert 110555 - sync: Remove ModelNeutralExecuteImpl() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/engine/model_changing_syncer_command.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/model_changing_syncer_command.h
===================================================================
--- chrome/browser/sync/engine/model_changing_syncer_command.h (revision 110571)
+++ chrome/browser/sync/engine/model_changing_syncer_command.h (working copy)
@@ -40,6 +40,14 @@
return UnrecoverableErrorInfo();
}
+ // Sometimes, a command has work to do that needs to touch global state
+ // belonging to multiple ModelSafeGroups, but in a way that is known to be
+ // safe. This will be called once, prior to ModelChangingExecuteImpl,
+ // *without* a ModelSafeGroup restriction in place on the SyncSession.
+ // Returns true on success, false on failure.
+ // TODO(tim): Remove this (bug 36594).
+ virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session);
+
// Abstract method to be implemented by subclasses to handle logic that
// operates on the model. This is invoked with a SyncSession ModelSafeGroup
// restriction in place so that bits of state belonging to data types
« no previous file with comments | « no previous file | chrome/browser/sync/engine/model_changing_syncer_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698