[cros, Aura] Make screen_mode static variable in StatusAreaViewChromeos

[cros] Make screen_mode static variable in StatusAreaViewChromeos.

In case of Aura status area is created once so status area buttons always use current value of screen_mode.

Added custom handling of ShouldExecuteStatusAreaCommand / ExecuteStatusAreaCommand() on login screen i.e. show only proxy settings dialog.

Changed InputMethodMenu so that it handles user sign in on Aura (where status area is not recreated on sign in).

BUG=104133
TEST=Booted into login screen, observed that status area items doesn't have "open options" items. Signed in, checked status area.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111526

[Nikita (slow), 2011-11-17 14:45:50]

Steven, Please take a look at this approach.

Not ready for review yet as InputMethodMenuButton does some assumptions based on
screen_mode in ctor and at that point StatusAreaViewChromeos::screen_mode is
still BROWSER_MODE (initial value).

I plan either setting it to LOGIN_MODE_WEBUI early on or (most likely) change
InputMethodMenuButton to handle changes of this state (notification).

[Nikita (slow), 2011-11-18 16:26:07]

Steven, please take a look, CL is ready for review.
Yusuke, please take a look at changes in InputMethodMenu.

[Yusuke Sato, 2011-11-19 00:36:59]

InputMethodMenu* lgtm

On 2011/11/18 16:26:07, Nikita Kostylev wrote:
> Steven, please take a look, CL is ready for review.
> Yusuke, please take a look at changes in InputMethodMenu.

[stevenjb, 2011-11-21 18:10:16]

Great cleanup, just one change I'd like to see.

http://codereview.chromium.org/8585031/diff/11001/chrome/browser/chromeos/sta...
File chrome/browser/chromeos/status/input_method_menu.cc (right):

http://codereview.chromium.org/8585031/diff/11001/chrome/browser/chromeos/sta...
chrome/browser/chromeos/status/input_method_menu.cc:170:
content::NotificationService::AllSources());
nit: Alignment

http://codereview.chromium.org/8585031/diff/11001/chrome/browser/chromeos/sta...
File chrome/browser/chromeos/status/status_area_view_chromeos.h (right):

http://codereview.chromium.org/8585031/diff/11001/chrome/browser/chromeos/sta...
chrome/browser/chromeos/status/status_area_view_chromeos.h:31: static ScreenMode
screen_mode;
We should not expose this publicly. Instead add SetScreenMode(). I don't think
we need a getter with the two methods below, but we can add one or another
Is...() if we need to. (We may want to add IsScreenLockerMode for completeness
even if we don't currently need it).

[Nikita (slow), 2011-11-22 09:01:27]

http://codereview.chromium.org/8585031/diff/11001/chrome/browser/chromeos/sta...
File chrome/browser/chromeos/status/input_method_menu.cc (right):

http://codereview.chromium.org/8585031/diff/11001/chrome/browser/chromeos/sta...
chrome/browser/chromeos/status/input_method_menu.cc:170:
content::NotificationService::AllSources());
On 2011/11/21 18:10:16, Steven Bennetts wrote:
> nit: Alignment

Done.

http://codereview.chromium.org/8585031/diff/11001/chrome/browser/chromeos/sta...
File chrome/browser/chromeos/status/status_area_view_chromeos.h (right):

http://codereview.chromium.org/8585031/diff/11001/chrome/browser/chromeos/sta...
chrome/browser/chromeos/status/status_area_view_chromeos.h:31: static ScreenMode
screen_mode;
On 2011/11/21 18:10:16, Steven Bennetts wrote:
> We should not expose this publicly. Instead add SetScreenMode(). I don't think
> we need a getter with the two methods below, but we can add one or another
> Is...() if we need to. (We may want to add IsScreenLockerMode for completeness
> even if we don't currently need it).

Done.

[stevenjb, 2011-11-22 20:24:57]

LGTM!

[commit-bot: I haz the power, 2011-11-23 17:04:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/8585031/22001

[commit-bot: I haz the power, 2011-11-23 18:27:15]

Try job failure for 8585031-22001 (retry) on mac_rel for step "media_unittests".
It's a second try, previously, step "media_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-11-24 12:58:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/8585031/23026

[commit-bot: I haz the power, 2011-11-24 14:13:07]

Change committed as 111526