Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/chromeos/status/network_menu_button.cc

Issue 8585031: [cros, Aura] Make screen_mode static variable in StatusAreaViewChromeos (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/status/network_menu_button.cc
diff --git a/chrome/browser/chromeos/status/network_menu_button.cc b/chrome/browser/chromeos/status/network_menu_button.cc
index 96bbcf4524b23cde619c99f2397dfe40033319c8..f58461d60a4f8dc161e2e1826169fdcd71651595 100644
--- a/chrome/browser/chromeos/status/network_menu_button.cc
+++ b/chrome/browser/chromeos/status/network_menu_button.cc
@@ -21,6 +21,7 @@
#include "chrome/browser/chromeos/login/user_manager.h"
#include "chrome/browser/chromeos/options/network_config_view.h"
#include "chrome/browser/chromeos/sim_dialog_delegate.h"
+#include "chrome/browser/chromeos/status/status_area_view_chromeos.h"
#include "chrome/browser/chromeos/view_ids.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
@@ -97,18 +98,14 @@ namespace chromeos {
////////////////////////////////////////////////////////////////////////////////
// NetworkMenuButton
-NetworkMenuButton::NetworkMenuButton(
- StatusAreaButton::Delegate* delegate,
- StatusAreaViewChromeos::ScreenMode screen_mode)
+NetworkMenuButton::NetworkMenuButton(StatusAreaButton::Delegate* delegate)
: StatusAreaButton(delegate, this),
mobile_data_bubble_(NULL),
- is_browser_mode_(false),
check_for_promo_(true),
was_sim_locked_(false),
ALLOW_THIS_IN_INITIALIZER_LIST(weak_ptr_factory_(this)) {
set_id(VIEW_ID_STATUS_BUTTON_NETWORK_MENU);
- is_browser_mode_ = (screen_mode == StatusAreaViewChromeos::BROWSER_MODE);
- network_menu_.reset(new NetworkMenu(this, is_browser_mode_));
+ network_menu_.reset(new NetworkMenu(this));
network_icon_.reset(
new NetworkMenuIcon(this, NetworkMenuIcon::MENU_MODE));
@@ -367,7 +364,8 @@ void NetworkMenuButton::ShowOptionalMobileDataPromoNotification(
// Display one-time notification for non-Guest users on first use
// of Mobile Data connection or if there's a carrier deal defined
// show that even if user has already seen generic promo.
- if (is_browser_mode_ && !UserManager::Get()->IsLoggedInAsGuest() &&
+ if (StatusAreaViewChromeos::IsBrowserMode() &&
+ !UserManager::Get()->IsLoggedInAsGuest() &&
check_for_promo_ && BrowserList::GetLastActive() &&
cros->cellular_connected() && !cros->ethernet_connected() &&
!cros->wifi_connected()) {
« no previous file with comments | « chrome/browser/chromeos/status/network_menu_button.h ('k') | chrome/browser/chromeos/status/status_area_view_chromeos.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698