Issue 8585027: Moving checkboxes to a separate column.

Issue 8585027: Moving checkboxes to a separate column. (Closed)

Created:
9 years, 1 month ago by SeRya

Modified:
9 years, 1 month ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Moving checkboxes to a separate column. In the File Manager list view icons are moved to the name column. Checkbox column made unsortable. +bugfixes. BUG=chromium-os:20156 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110501

Patch Set 1 #

Patch Set 2 : Revering some changes #

Total comments: 2

Patch Set 3 : Code review fix #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -113 lines)			Patch
M	chrome/browser/resources/file_manager/css/file_manager.css	View		4 chunks	+6 lines, -28 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2	13 chunks	+67 lines, -77 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/metadata_provider.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/array_data_model.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/cr/ui/table/table_header.js	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

LGTM with a comment http://codereview.chromium.org/8585027/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/8585027/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js#newcode483 chrome/browser/resources/file_manager/js/file_manager.js:483: self.mountPoints_ = mountPoints; nit: identation?

9 years, 1 month ago (2011-11-17 13:43:45 UTC) #2

SeRya

http://codereview.chromium.org/8585027/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/8585027/diff/2001/chrome/browser/resources/file_manager/js/file_manager.js#newcode483 chrome/browser/resources/file_manager/js/file_manager.js:483: self.mountPoints_ = mountPoints; On 2011/11/17 13:43:46, Vladislav Kaznacheev wrote: ...

9 years, 1 month ago (2011-11-17 14:04:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/8585027/17

9 years, 1 month ago (2011-11-17 14:04:32 UTC) #4

Change committed as 110501

Expand Messages | Collapse Messages