chrome/browser/resources/shared/js/cr/ui/table/table_header.js - Issue 8585027: Moving checkboxes to a separate column.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/table/table_header.js

Issue 8585027: Moving checkboxes to a separate column. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review fix Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/shared/js/cr/ui/table/table_header.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/table/table_header.js b/chrome/browser/resources/shared/js/cr/ui/table/table_header.js

index 0bbafa6fa3a2fcb3940821e3b3342a39e12b3d97..88d04a77d507ce2b31b19cff62b4bfd514836a84 100644

--- a/chrome/browser/resources/shared/js/cr/ui/table/table_header.js

+++ b/chrome/browser/resources/shared/js/cr/ui/table/table_header.js

@@ -80,7 +80,9 @@ cr.define('cr.ui.table', function() {

var cell = this.ownerDocument.createElement('div');

cell.style.width = cm.getWidth(i) + '%';

cell.className = 'table-header-cell';

- cell.addEventListener('click', this.createSortFunction_(i).bind(this));

+ if (dm.isSortable(cm.getId(i)))

+ cell.addEventListener('click',

+ this.createSortFunction_(i).bind(this));

cell.appendChild(this.createHeaderLabel_(i));

this.headerInner_.appendChild(cell);

« no previous file with comments | « chrome/browser/resources/shared/js/cr/ui/array_data_model.js ('k') | no next file » | no next file with comments »