Issue 8585013: Merge definitions of PlatformFileToInt and IntToPlatformFile to one place.

Issue 8585013: Merge definitions of PlatformFileToInt and IntToPlatformFile to one place. (Closed)

Created:
9 years, 1 month ago by xhwang

Modified:
9 years, 1 month ago

Reviewers:
brettw, ddorwin, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Merge definitions of PlatformFileToInt and IntToPlatformFile to one place. BUG=none TEST=normal browsing on m17 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111447

Patch Set 2 : Rebased and moved function definitions to .cc file. #

Patch Set 3 : Add include of ppapi/c/pp_stdint.h to fix compiling error on Win. #

Patch Set 4 : Move to ppapi/shared_impl to solve dependency issue. #

Patch Set 5 : Add PPAPI_SHARED_EXPORT to make component build work. #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -101 lines)			Patch
M	content/renderer/pepper_plugin_delegate_impl.cc	View	1 2 3	5 chunks	+5 lines, -13 lines	0 comments	Download
M	ppapi/ppapi_shared.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ppapi/proxy/broker_dispatcher.cc	View	1 2 3	2 chunks	+3 lines, -15 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_input_proxy.cc	View	1 2 3	3 chunks	+2 lines, -16 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	1 2 3	3 chunks	+2 lines, -16 lines	0 comments	Download
M	ppapi/proxy/ppb_broker_proxy.cc	View	1 2 3	1 chunk	+4 lines, -25 lines	0 comments	Download
A	ppapi/shared_impl/platform_file.h	View	1 2 3 4	1 chunk	+19 lines, -0 lines	0 comments	Download
A	ppapi/shared_impl/platform_file.cc	View	1 2 3	1 chunk	+31 lines, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_broker_impl.cc	View	1 2 3	1 chunk	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

xhwang

Hello David, Could you please do a code review on this change. Thanks! Xiaohan

9 years, 1 month ago (2011-11-17 01:43:24 UTC) #1

xhwang

Hello piman and brettw, Could you please do an OWNERS review on this change? -xiaohan

9 years, 1 month ago (2011-11-21 23:22:37 UTC) #2

piman

http://codereview.chromium.org/8585013/diff/1/ppapi/proxy/proxy_channel.h File ppapi/proxy/proxy_channel.h (right): http://codereview.chromium.org/8585013/diff/1/ppapi/proxy/proxy_channel.h#newcode47 ppapi/proxy/proxy_channel.h:47: } I'm not sure these functions belong to this ...

9 years, 1 month ago (2011-11-22 20:20:36 UTC) #3

xhwang

Rebased and moved definitions to .cc file. http://codereview.chromium.org/8585013/diff/1/ppapi/proxy/proxy_channel.h File ppapi/proxy/proxy_channel.h (right): http://codereview.chromium.org/8585013/diff/1/ppapi/proxy/proxy_channel.h#newcode47 ppapi/proxy/proxy_channel.h:47: } On ...

9 years, 1 month ago (2011-11-22 23:22:57 UTC) #4

xhwang

Hello piman and brettw, Moved PlatformFileToInt and IntToPlatformFile to new files under ppapi/shared_impl to fix ...

9 years, 1 month ago (2011-11-23 21:10:06 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/8585013/22005

9 years, 1 month ago (2011-11-23 22:02:07 UTC) #8

Change committed as 111447

Expand Messages | Collapse Messages