Merge definitions of PlatformFileToInt and IntToPlatformFile to one place.

ppapi/proxy/proxy_channel.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_PROXY_PROXY_CHANNEL_H_
 #define PPAPI_PROXY_PROXY_CHANNEL_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "base/process.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_platform_file.h"
 #include "ipc/ipc_sync_channel.h"
 #include "ppapi/proxy/ppapi_proxy_export.h"
 
 namespace base {
 class MessageLoopProxy;
 class WaitableEvent;
 }
 
 namespace IPC {
 class TestSink;
 }
 
 namespace ppapi {
 namespace proxy {
 
+// TODO(piman/brettw): Change trusted interface to return a PP_FileHandle,
+// those casts are ugly.
+inline base::PlatformFile IntToPlatformFile(int32_t handle) {
+#if defined(OS_WIN)
+  return reinterpret_cast<HANDLE>(static_cast<intptr_t>(handle));
+#elif defined(OS_POSIX)
+  return handle;
+#else
+  #error Not implemented.
+#endif
+}
+
+inline int32_t PlatformFileToInt(base::PlatformFile handle) {
+#if defined(OS_WIN)
+  return static_cast<int32_t>(reinterpret_cast<intptr_t>(handle));
+#elif defined(OS_POSIX)
+  return handle;
+#else
+  #error Not implemented.
+#endif
+}

[piman, 2011/11/22 20:20:36]

I'm not sure these functions belong to this file... Mind putting them in a
separate one? Also, I don't think they need to be inline.

[xhwang, 2011/11/22 23:22:58]

As discussed offline, these functions will stay in this file.  But the
definition will be moved to .cc file.

+
 class PPAPI_PROXY_EXPORT ProxyChannel
     : public IPC::Channel::Listener,
       public IPC::Message::Sender {
  public:
   typedef void (*ShutdownModuleFunc)();
 
   class PPAPI_PROXY_EXPORT Delegate {
    public:
     virtual ~Delegate() {}
 
@@ skipping 66 matching lines @@
   // remote side has crashed.
   scoped_ptr<IPC::SyncChannel> channel_;
 
   DISALLOW_COPY_AND_ASSIGN(ProxyChannel);
 };
 
 }  // namespace proxy
 }  // namespace ppapi
 
 #endif  // PPAPI_PROXY_PROXY_CHANNEL_H_