chrome/browser/nacl_host/nacl_process_host.cc - Issue 8585002: Give base::SharedMemory::CreateAnonymous an executable flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/nacl_host/nacl_process_host.cc

Issue 8585002: Give base::SharedMemory::CreateAnonymous an executable flag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/nacl_host/nacl_process_host.cc

diff --git a/chrome/browser/nacl_host/nacl_process_host.cc b/chrome/browser/nacl_host/nacl_process_host.cc

index d254d4438ca1a7ff216074c577e4d7fb46eaf686..ae4b596645cf18273a8a8710cd61a9325878b328 100644

--- a/chrome/browser/nacl_host/nacl_process_host.cc

+++ b/chrome/browser/nacl_host/nacl_process_host.cc

@@ -504,7 +504,7 @@ void NaClProcessHost::SendStart(base::PlatformFile irt_file) {

// mappable with PROT_EXEC. Rather than requiring an extra IPC

// round trip out of the sandbox, we create an FD here.

base::SharedMemory memory_buffer;

- if (!memory_buffer.CreateAnonymous(/* size= */ 1)) {

+ if (!memory_buffer.CreateAnonymous(/* size= */ 1, true)) {

LOG(ERROR) << "Failed to allocate memory buffer";

delete this;

return;