Give base::SharedMemory::CreateAnonymous an executable flag

base/metrics/stats_table.cc

Index: base/metrics/stats_table.cc
diff --git a/base/metrics/stats_table.cc b/base/metrics/stats_table.cc
index 2bccc908ab97b9e8287bbc6854560856eddcca4a..d5463c9a4ed27e20af1931723cd3982dc86cbeca 100644
--- a/base/metrics/stats_table.cc
+++ b/base/metrics/stats_table.cc
@@ -168,7 +168,7 @@ StatsTable::Private* StatsTable::Private::New(const std::string& name,
                                               int max_threads,
                                               int max_counters) {
   scoped_ptr<Private> priv(new Private());
-  if (!priv->shared_memory_.CreateNamed(name, true, size))
+  if (!priv->shared_memory_.CreateNamed(name, true, size, false))

[Mark Mentovai, 2011/11/29 20:10:44]

I’m looking at uses like this. What’s true? What’s false? Gotta go read the
header for shared memory. That’s too bad.

As an alternative to the options struct, you can replace the bools with named
enums, so callers can pass values like OPEN_EXISTING. But that still leaves the
problem that extending the function requires you to touch all of the call sites,
which isn’t the case with an options struct.

     return NULL;
   if (!priv->shared_memory_.Map(size))
     return NULL;