Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3359)

Unified Diff: base/shared_memory_posix.cc

Issue 8585002: Give base::SharedMemory::CreateAnonymous an executable flag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/shared_memory_posix.cc
diff --git a/base/shared_memory_posix.cc b/base/shared_memory_posix.cc
index 3e5699ad00abdd95e5426679a833853f130569a2..3b14e79e591e1494887dbc14306100e8bc08b3cc 100644
--- a/base/shared_memory_posix.cc
+++ b/base/shared_memory_posix.cc
@@ -95,11 +95,11 @@ void SharedMemory::CloseHandle(const SharedMemoryHandle& handle) {
}
bool SharedMemory::CreateAndMapAnonymous(uint32 size) {
- return CreateAnonymous(size) && Map(size);
+ return CreateAnonymous(size, false) && Map(size);
}
-bool SharedMemory::CreateAnonymous(uint32 size) {
- return CreateNamed("", false, size);
+bool SharedMemory::CreateAnonymous(uint32 size, bool executable) {
+ return CreateNamed("", false, size, executable);
}
#if !defined(OS_ANDROID)
@@ -109,8 +109,8 @@ bool SharedMemory::CreateAnonymous(uint32 size) {
// we restart from a crash. (That isn't a new problem, but it is a problem.)
// In case we want to delete it later, it may be useful to save the value
// of mem_filename after FilePathForMemoryName().
-bool SharedMemory::CreateNamed(const std::string& name,
- bool open_existing, uint32 size) {
+bool SharedMemory::CreateNamed(const std::string& name, bool open_existing,
+ uint32 size, bool executable) {
DCHECK_EQ(-1, mapped_file_);
if (size == 0) return false;

Powered by Google App Engine
This is Rietveld 408576698