Give base::SharedMemory::CreateAnonymous an executable flag

base/metrics/stats_table.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/stats_table.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/process_util.h"
 #include "base/shared_memory.h"
@@ skipping 150 matching lines @@
   char* counter_names_table_;
   int* data_table_;
 };
 
 // static
 StatsTable::Private* StatsTable::Private::New(const std::string& name,
                                               int size,
                                               int max_threads,
                                               int max_counters) {
   scoped_ptr<Private> priv(new Private());
-  if (!priv->shared_memory_.CreateNamed(name, true, size))
+  if (!priv->shared_memory_.CreateNamed(name, true, size, false))

[Mark Mentovai, 2011/11/29 20:10:44]

I’m looking at uses like this. What’s true? What’s false? Gotta go read the
header for shared memory. That’s too bad.

As an alternative to the options struct, you can replace the bools with named
enums, so callers can pass values like OPEN_EXISTING. But that still leaves the
problem that extending the function requires you to touch all of the call sites,
which isn’t the case with an options struct.

     return NULL;
   if (!priv->shared_memory_.Map(size))
     return NULL;
   void* memory = priv->shared_memory_.memory();
 
   TableHeader* header = static_cast<TableHeader*>(memory);
 
   // If the version does not match, then assume the table needs
   // to be initialized.
   if (header->version != kTableVersion)
@@ skipping 369 matching lines @@
     static_cast<TLSData*>(tls_index_.Get());
   if (!data)
     return NULL;
 
   DCHECK(data->slot);
   DCHECK_EQ(data->table, this);
   return data;
 }
 
 }  // namespace base