Fixed DefaultNotificationsSetting on ChromeOS.

Fixed DefaultNotificationsSetting on ChromeOS.

BUG=chromium-os:23079
TEST=policy_prefs_ui.py passes on chromeos for all policies

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111120

[Joao da Silva, 2011-11-21 22:35:37]

Markus: I've verified that this indeed fixes the glitch on chromeos. It's not
only a UI glitch, the policy itself isn't being applied at all. Please review.

Mattias: FYI
Kris: FYI. Thanks for the bug report, I've managed to replicate this.

[markusheintz_, 2011-11-22 08:51:58]

LGTM with one nit

http://codereview.chromium.org/8584004/diff/1/chrome/app/policy/policy_templa...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/8584004/diff/1/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.json:1413: 'supported_on': ['chrome.*:10-',
'chrome_os:0.11-'],
Are you sure that is works for old versions as well, after this fix landed?

[Joao da Silva, 2011-11-22 09:10:20]

http://codereview.chromium.org/8584004/diff/1/chrome/app/policy/policy_templa...
File chrome/app/policy/policy_templates.json (right):

http://codereview.chromium.org/8584004/diff/1/chrome/app/policy/policy_templa...
chrome/app/policy/policy_templates.json:1413: 'supported_on': ['chrome.*:10-',
'chrome_os:0.11-'],
On 2011/11/22 08:51:58, markusheintz_ wrote:
> Are you sure that is works for old versions as well, after this fix landed?

It was working before. This problem was a regression introduced by these changes
together:

- http://codereview.chromium.org/8258018 (automatically generate list of
policies from the template)
- http://codereview.chromium.org/8467011 (only generate the policies listed for
each platform)

This template has been "fixed" before for other policies, that weren't working
after those cleanups. One such CL: http://codereview.chromium.org/8555012

[Mattias Nissler (ping if slow), 2011-11-22 15:15:03]

LGTM